Closed Bug 374404 Opened 14 years ago Closed 14 years ago

Don't ship WidgetStateManager as part of toolkit

Categories

(Toolkit Graveyard :: Build Config, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9alpha4

People

(Reporter: asqueella, Assigned: asqueella)

References

()

Details

Attachments

(2 files)

See http://mxr.mozilla.org/seamonkey/search?string=widgetstatemanager

These two files are not actually used by either Firefox or Thunderbird.
http://mxr.mozilla.org/seamonkey/source/toolkit/content/nsWidgetStateManager.js
http://mxr.mozilla.org/seamonkey/source/toolkit/obsolete/content/widgetStateManager.js

The suite has its own version of these in xpfe/. The toolkit version should be removed.
(It was pointed out that suiterunner does use the files from toolkit, need to avoid breaking it.)
(http://mxr.mozilla.org/seamonkey/source/embedding/config/xulprefs.mn, which references one of these files appears unused)
Component: General → Build Config
Product: Firefox → Toolkit
QA Contact: general → build-config
Given what we now know about wsm (wigetstatemanager), I'm currently investigating (=building) using the xpfe version of the wsm for SeaMonkey (both xpfe & toolkit builds). This would resolve some of our suiterunner pref problems (due to using toolkit's wsm) and help to get the right resolution for this bug.
(In reply to comment #3)
>This would resolve some of our suiterunner pref problems
I guess I'd get to back out the patch that works around one of them ;-)
The patch I'm just about to post for SeaMonkey/suiterunner will fix bug 370308 as well, I originally thought it'd fix bug 361191 as well, but it doesn't seem to on my build.
Blocks: 370308
This copies the nsWidgetStateManager.js from xpfe/... to suite/... and updates the relevant file - I haven't included the cvs copy in this patch.

I'd like to do a bit more investigation as to why it doesn't fix bug 361191 before I ask for reviews, just in case I've missed something.
(In reply to comment #5)
> The patch I'm just about to post for SeaMonkey/suiterunner will fix bug 370308
> as well, I originally thought it'd fix bug 361191 as well, but it doesn't seem
> to on my build.

It helps if I don't have other part patches in my tree - this patch will fix bug 361191 as well.
Blocks: 361191
Comment on attachment 259035 [details] [diff] [review]
Copies nsWidgetStateManager.js from xpfe to suite for SeaMonkey (checked in)

Neil, I'm assuming your review will be sufficient for sr as well?
Attachment #259035 - Flags: first-review?(neil)
footprint key word
Comment on attachment 259035 [details] [diff] [review]
Copies nsWidgetStateManager.js from xpfe to suite for SeaMonkey (checked in)

>+   content/communicator/pref/nsWidgetStateManager.js                (pref/nsWidgetStateManager.js)
I don't think we need to copy this file as we'll eventually switch to xbl preferences, so just directly package the xpfe file here.
Attachment #259035 - Flags: first-review?(neil) → first-review+
Comment on attachment 259035 [details] [diff] [review]
Copies nsWidgetStateManager.js from xpfe to suite for SeaMonkey (checked in)

I just checked this in, without copying the xpfe file as Neil suggested.
Attachment #259035 - Attachment description: Copies nsWidgetStateManager.js from xpfe to suite for SeaMonkey → Copies nsWidgetStateManager.js from xpfe to suite for SeaMonkey (checked in)
Note bug 273287 can probably be resolved wontfix/invalid when this is fixed...
I didn't test Thunderbird, although code inspection says TB doesn't use wsm.

I don't know what xulprefs.mn is supposed to be for or how would I go about testing it, but it doesn't appear to be used, looks out of date anyway, and appears to rely on the Suite build anyway.
Attachment #259558 - Flags: first-review?(benjamin)
Status: NEW → ASSIGNED
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9alpha4
Comment on attachment 259558 [details] [diff] [review]
remove from toolkit and mail

Er, I do not remove xulprefs.mn in this patch.
Attachment #259558 - Attachment description: remove from toolkit and mail; also remove xulprefs.mn → remove from toolkit and mail
Attachment #259558 - Flags: first-review?(benjamin) → first-review+
mozilla/mail/config/mail-jar.mn                         1.53
mozilla/toolkit/content/jar.mn                          1.30
mozilla/toolkit/content/nsWidgetStateManager.js         delete
mozilla/toolkit/obsolete/jar.mn                         1.4
mozilla/toolkit/obsolete/content/widgetStateManager.js  delete
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.