374404 - Don't ship WidgetStateManager as part of toolkit

Status: RESOLVED FIXED

(Toolkit Graveyard :: Build Config, defect)

Description

[Nickolay_Ponomarev]

See http://mxr.mozilla.org/seamonkey/search?string=widgetstatemanager

These two files are not actually used by either Firefox or Thunderbird.
http://mxr.mozilla.org/seamonkey/source/toolkit/content/nsWidgetStateManager.js
http://mxr.mozilla.org/seamonkey/source/toolkit/obsolete/content/widgetStateManager.js

The suite has its own version of these in xpfe/. The toolkit version should be removed.

Comment 1

[Nickolay_Ponomarev]

(It was pointed out that suiterunner does use the files from toolkit, need to avoid breaking it.)

Comment 2

[Nickolay_Ponomarev]

(http://mxr.mozilla.org/seamonkey/source/embedding/config/xulprefs.mn, which references one of these files appears unused)

Comment 3

[Mark Banner (:standard8)]

Given what we now know about wsm (wigetstatemanager), I'm currently investigating (=building) using the xpfe version of the wsm for SeaMonkey (both xpfe & toolkit builds). This would resolve some of our suiterunner pref problems (due to using toolkit's wsm) and help to get the right resolution for this bug.

Comment 4

[[e-mail]]

(In reply to comment #3)
>This would resolve some of our suiterunner pref problems
I guess I'd get to back out the patch that works around one of them ;-)

Comment 5

[Mark Banner (:standard8)]

The patch I'm just about to post for SeaMonkey/suiterunner will fix bug 370308 as well, I originally thought it'd fix bug 361191 as well, but it doesn't seem to on my build.

Comment 6

[Mark Banner (:standard8)]

Attachment: Copies nsWidgetStateManager.js from xpfe to suite for SeaMonkey (checked in)

This copies the nsWidgetStateManager.js from xpfe/... to suite/... and updates the relevant file - I haven't included the cvs copy in this patch.

I'd like to do a bit more investigation as to why it doesn't fix bug 361191 before I ask for reviews, just in case I've missed something.

Comment 7

[Mark Banner (:standard8)]

(In reply to comment #5)
> The patch I'm just about to post for SeaMonkey/suiterunner will fix bug 370308
> as well, I originally thought it'd fix bug 361191 as well, but it doesn't seem
> to on my build.

It helps if I don't have other part patches in my tree - this patch will fix bug 361191 as well.

Comment 8

[Mark Banner (:standard8)]

Comment on attachment 259035 [details] [diff] [review]
Copies nsWidgetStateManager.js from xpfe to suite for SeaMonkey (checked in)

Neil, I'm assuming your review will be sufficient for sr as well?

Comment 9

[Worcester12345]

footprint key word

Comment 10

[[e-mail]]

Comment on attachment 259035 [details] [diff] [review]
Copies nsWidgetStateManager.js from xpfe to suite for SeaMonkey (checked in)

>+   content/communicator/pref/nsWidgetStateManager.js                (pref/nsWidgetStateManager.js)
I don't think we need to copy this file as we'll eventually switch to xbl preferences, so just directly package the xpfe file here.

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 259035 [details] [diff] [review]
Copies nsWidgetStateManager.js from xpfe to suite for SeaMonkey (checked in)

I just checked this in, without copying the xpfe file as Neil suggested.

Comment 12

[Mark Banner (:standard8)]

Note bug 273287 can probably be resolved wontfix/invalid when this is fixed...

Comment 13

[Nickolay_Ponomarev]

Attachment: remove from toolkit and mail

I didn't test Thunderbird, although code inspection says TB doesn't use wsm.

I don't know what xulprefs.mn is supposed to be for or how would I go about testing it, but it doesn't appear to be used, looks out of date anyway, and appears to rely on the Suite build anyway.

Comment 14

[Nickolay_Ponomarev]

Comment on attachment 259558 [details] [diff] [review]
remove from toolkit and mail

Er, I do not remove xulprefs.mn in this patch.

Comment 15

[Nickolay_Ponomarev]

mozilla/mail/config/mail-jar.mn                         1.53
mozilla/toolkit/content/jar.mn                          1.30
mozilla/toolkit/content/nsWidgetStateManager.js         delete
mozilla/toolkit/obsolete/jar.mn                         1.4
mozilla/toolkit/obsolete/content/widgetStateManager.js  delete