361240 - Context menu in download manager is busted

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Jesse Ruderman]

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20061119 Minefield/3.0a1

Steps to reproduce:
1. Download something (e.g. option+click a link)
2. Open download manager
3. Ctrl+click an item in the download manager to open a context menu

Result: the selected item in the download manager becomes unselected.

4. Select "show in finder" or "properties".

Result: the context menu goes away but nothing happens.

I'm guessing this is Mac-only and a regression from cocoa.

Comment 1

[Jesse Ruderman]

Works fine in a non-Cocoa build, so I'm pretty sure this is a regression from Cocoa.

Comment 2

[Phil Ringnalda (:philor)]

Cocoa indeed, and probably another instance of bug 355095

Comment 3

[Stefan [:stefanh]]

See also bug 357417.

Comment 4

[Josh Aas]

Attachment: fix v1.0

Comment 5

[Phil Ringnalda (:philor)]

*** Bug 355095 has been marked as a duplicate of this bug. ***

Comment 6

[Phil Ringnalda (:philor)]

*** Bug 357417 has been marked as a duplicate of this bug. ***

Comment 7

[Håkan Waara]

Comment on attachment 246066 [details] [diff] [review]
fix v1.0

>Index: nsChildView.mm
>===================================================================
>RCS file: /cvsroot/mozilla/widget/src/cocoa/nsChildView.mm,v
>retrieving revision 1.192
>diff -U8 -r1.192 nsChildView.mm
>--- nsChildView.mm	20 Nov 2006 05:37:49 -0000	1.192
>+++ nsChildView.mm	20 Nov 2006 20:47:37 -0000
>@@ -2675,17 +2675,20 @@
> #if USE_CLICK_HOLD_CONTEXTMENU
>   // fire off timer to check for click-hold after two seconds. retains |theEvent|
>   [self performSelector:@selector(clickHoldCallback:) withObject:theEvent afterDelay:2.0];
> #endif
> 
>   nsMouseEvent geckoEvent(PR_TRUE, 0, nsnull, nsMouseEvent::eReal);
>   [self convertEvent:theEvent message:NS_MOUSE_BUTTON_DOWN toGeckoEvent:&geckoEvent];
>   geckoEvent.clickCount = [theEvent clickCount];
>-  geckoEvent.button = nsMouseEvent::eLeftButton;
>+  if ([theEvent modifierFlags] & NSControlKeyMask)
>+    geckoEvent.button = nsMouseEvent::eRightButton;
>+  else
>+    geckoEvent.button = nsMouseEvent::eLeftButton;

What if some control wants to respond to proper right clicks but do not want ctrl-click associated with it? Can we pass down the NS_CONTEXTMENU event explicitly instead of faking a right-click?

Comment 8

[Josh Aas]

Attachment: fix v2.0

Yeah, on second thought we should just fix the XUL widget which is using the wrong modifier key for row deselection on mac.

Comment 9

[Phil Ringnalda (:philor)]

So should I reopen the bugs on SeaMonkey's link click, and the Firefox bookmarks toolbar, and whatever other things we can find that thought that it was up to another layer to associate Mac ctrl+click with right-click (as we apparently did before, since it used to work)?

Comment 10

[Josh Aas]

Lets wait and see how the approach in fix v2.0 does in review.

Comment 11

[Neil Deakin]

Comment on attachment 246333 [details] [diff] [review]
fix v2.0

Of course, it shouldn't actually be using any key to deselect, but this looks OK to fix the regression.

Comment 12

[Josh Aas]

landed on trunk