361393 - check for updates button is cut where interface is RTL

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Reuven Gonen]

in the Hebrew version of Firefox the "Check for updates" button in the bottom of the Addon manager is cut in the middle.

this is caused because of a workaround for Bug 240536. in the intl.css file the resizer is set to display: none;. a workaround for this bug can be to not display the resizerbox.

Comment 1

[Reuven Gonen]

Attachment: screenshot showing the problem

Comment 2

[Reuven Gonen]

Attachment: hiding the resizerbox in intl.css

this patch hides the resizerbox from being displayed in the bottom of the addon manager.

Comment 3

[Asaf Romano (gone)]

Comment on attachment 246160 [details] [diff] [review]
hiding the resizerbox in intl.css

r=mano as a temporary workaround, but please change this to

#extensionsManager #resizerBox {
  dispaly: none;
}

so the chance for this to break random extensions (which use the same id) is smaller.

Comment 4

[Asaf Romano (gone)]

display*

Comment 5

[Reuven Gonen]

Attachment: addressing mano's comment

Comment 6

[Asaf Romano (gone)]

Comment on attachment 246169 [details] [diff] [review]
addressing mano's comment

you need l10n approval AFAICT.

Comment 7

[Reuven Gonen]

Attachment: hiding the resizerbox - he locale update

asking for approval for the changes to the he language only, until we get feedback from the ar locale owner/s.

Comment 8

[Axel Hecht [:Pike]]

Comment on attachment 246692 [details] [diff] [review]
hiding the resizerbox - he locale update

[he] approval for RTL hack for the MOZILLA_1_8_BRANCH.

Please land ASAP and use the fixed1.8.1.1 and verified1.8.1.1 keywords to track landing and testing.

I guess that bug 240536 could use a backout-patch for all these hacks so that it's clear what to undo once that bug gets fixed.

Comment 9

[Steve England [:stevee]]

--> RESOLVED FIXED?

Comment 10

[Reuven Gonen]

(In reply to comment #9)
> --> RESOLVED FIXED?
> 

this is not fixed yet in other RTL locales

Comment 11

[Axel Hecht [:Pike]]

Let's resolve this bug FIXED so that we can get our hebrew release tracking out the door. Please file separate bugs on other RTL locales.

Comment 12

[(no longer active)]

Mass-assigning the new rtl keyword to RTL-related (see bug 349193).