check for updates button is cut where interface is RTL

RESOLVED FIXED

Status

()

Toolkit
Add-ons Manager
RESOLVED FIXED
12 years ago
10 years ago

People

(Reporter: Reuven Gonen, Unassigned)

Tracking

({fixed1.8.1.1, rtl, verified1.8.1.1})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

12 years ago
in the Hebrew version of Firefox the "Check for updates" button in the bottom of the Addon manager is cut in the middle.

this is caused because of a workaround for Bug 240536. in the intl.css file the resizer is set to display: none;. a workaround for this bug can be to not display the resizerbox.
(Reporter)

Comment 1

12 years ago
Created attachment 246158 [details]
screenshot showing the problem
(Reporter)

Comment 2

12 years ago
Created attachment 246160 [details] [diff] [review]
hiding the resizerbox in intl.css

this patch hides the resizerbox from being displayed in the bottom of the addon manager.
Attachment #246160 - Flags: review?
(Reporter)

Updated

12 years ago
Attachment #246160 - Flags: review? → review?(mano)
Comment on attachment 246160 [details] [diff] [review]
hiding the resizerbox in intl.css

r=mano as a temporary workaround, but please change this to

#extensionsManager #resizerBox {
  dispaly: none;
}

so the chance for this to break random extensions (which use the same id) is smaller.
Attachment #246160 - Flags: review?(mano) → review+
(Reporter)

Comment 5

12 years ago
Created attachment 246169 [details] [diff] [review]
addressing mano's comment
Attachment #246160 - Attachment is obsolete: true
Attachment #246169 - Flags: review?(mano)
Attachment #246169 - Flags: approval-l10n?
(Reporter)

Updated

12 years ago
Attachment #246169 - Flags: approval-l10n? → approval1.8.1.1?
Comment on attachment 246169 [details] [diff] [review]
addressing mano's comment

you need l10n approval AFAICT.
Attachment #246169 - Flags: review?(mano)
Attachment #246169 - Flags: review+
Attachment #246169 - Flags: approval1.8.1.1?
(Reporter)

Comment 7

12 years ago
Created attachment 246692 [details] [diff] [review]
hiding the resizerbox - he locale update

asking for approval for the changes to the he language only, until we get feedback from the ar locale owner/s.
Attachment #246692 - Flags: approval1.8.1.1?

Comment 8

12 years ago
Comment on attachment 246692 [details] [diff] [review]
hiding the resizerbox - he locale update

[he] approval for RTL hack for the MOZILLA_1_8_BRANCH.

Please land ASAP and use the fixed1.8.1.1 and verified1.8.1.1 keywords to track landing and testing.

I guess that bug 240536 could use a backout-patch for all these hacks so that it's clear what to undo once that bug gets fixed.
Attachment #246692 - Flags: approval1.8.1.1? → approval1.8.1.1+
(Reporter)

Updated

12 years ago
Keywords: fixed1.8.1.1
--> RESOLVED FIXED?
(Reporter)

Comment 10

12 years ago
(In reply to comment #9)
> --> RESOLVED FIXED?
> 

this is not fixed yet in other RTL locales
Keywords: verified1.8.1.1

Updated

12 years ago
Blocks: 352116

Comment 11

12 years ago
Let's resolve this bug FIXED so that we can get our hebrew release tracking out the door. Please file separate bugs on other RTL locales.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Comment 12

10 years ago
Mass-assigning the new rtl keyword to RTL-related (see bug 349193).
Keywords: rtl
(Assignee)

Updated

10 years ago
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.