352116 - (fx20-he) [he] Ship Firefox 2

Status: RESOLVED FIXED

(Mozilla Localizations :: he / Hebrew, defect)

Description

[Axel Hecht [:Pike]]

Looking at http://people.mozilla.com/~axel/status-1.8/ and http://tinderbox.mozilla.org/showbuilds.cgi?tree=Mozilla1.8-l10n-he, the hebrew localisation is behind quite a bit.
Help is broken too, as has been reported in bug 344312.

I'm not setting a milestone on this, waiting for input from the l10n team here.

Comment 1

[Tomer Cohen :tomer]

I am the person to blame. I need time to finish the project toward 2.0 and CVS access (bug 343315). 

Please assign to me and make it depend on bug 343315.

Comment 2

[Axel Hecht [:Pike]]

Reassigning to Tomer.

I boosted your privs, too, so that you can grab bugs now.

Comment 3

[Tomer Cohen :tomer]

After a terrible software crash which lead to data loss, the translation process is back on track. I have to complete the toolkit component translation, and migrate the browser help from version 1.5. 

Estimated completion time: 24 hours.  

Comment 4

[Axel Hecht [:Pike]]

Please don't check into the MOZILLA_1_8_BRANCH without explicit approval, it's closed. Just to make sure you understand that this affects all locales as of now.

Comment 5

[Tomer Cohen :tomer]

Who can manually approve it? I can email the locale to a driver or attach it here. 

Comment 6

[Axel Hecht [:Pike]]

I guess I'll just do a verbal approval without a patch. Just poke me when you're ready, and I'll sign it off when we have an engineering window.

Comment 7

[Tomer Cohen :tomer]

I have completed the language pack, hope there is no mistakes in there. The help file still outdated in we are working to complete it in the next day. Should I attach here the file? 

Comment 8

[Tomer Cohen :tomer]

Attachment: he translation for Firefox 2.0

He translation for Firefox 2.0. 

This file is work in progrss:
1. Localized search engines missing. See bug 348114 - We have two engines ready, but wish to get another one or two for inclusion (Waiting for site approvals). 
2. Help not updated. We are working toward finishing it in a day or so. Must of the job (prefs.xhtml) done.

Comment 9

[Axel Hecht [:Pike]]

Moving over to 2.0.0.1.

Comment 10

[Tomer Cohen :tomer]

Can we commit the translation to the CVS? It is quite strange that we have 3.0a1 but no 2.0. 

Comment 11

[Axel Hecht [:Pike]]

Now is the time for landing big changes towards Firefox 2.0.0.1.

a=me for the initial landing, please file follow-up bugs and attach patches on remaining issues coming up.

Comment 12

[Axel Hecht [:Pike]]

Apart from the search engines, I see english descriptions in bookmarks.html still. Could you fix those?

How does the rest of the Hebrew build look, is the testing progressing nicely?

Comment 13

[Tomer Cohen :tomer]

(In reply to comment #12)
> Apart from the search engines, I see english descriptions in bookmarks.html
> still. Could you fix those?
The translated bookmarks.html has few problems and replaced with the 1.5 version. I'm currently doing the bug hunting, and will have a working bookmarks.html in few hours. Also, the file has "BOOKMARKS TOOLBAR FOLDERr" (Caps are the translated string; note of the postfix "r" with has nothing to do here. 

 
> How does the rest of the Hebrew build look, is the testing progressing nicely?
The Translation is on track, and apart of few problems (The check for updates hangs with XUL error, the tree in the Help is not RTL) we are just fine for shipping. 

I'll attach fixes in the upcoming hours; CVS upload by our working-CVS-account peer will be possible only in about a day due to Sabbath.

Comment 14

[Asaf Romano (gone)]

Tomer: isn't the help tree issue basically bug 140759?

Comment 15

[Tomer Cohen :tomer]

(In reply to comment #14)
> Tomer: isn't the help tree issue basically bug 140759?
> 

It is. 

Comment 16

[Reuven Gonen]

Attachment: [fixed] some fixes to the he translation

fixes for the translation. including the searchplugins and the bookmarks.

Comment 17

[Axel Hecht [:Pike]]

Comment on attachment 245356 [details] [diff] [review]
[fixed] some fixes to the he translation

[he] approval to land additional fixes to make hebrew ready for release.

We still need Mic on the plugins themselves in the search engines bug, I'll look at the technicalities of the plugins once this patch landed.

Comment 18

[Reuven Gonen]

Attachment: additional fixes to the he translation

additional fixes for the translation. we hope to get the rest of the help section translated before 2.0.0.1/

Comment 19

[Tomer Cohen :tomer]

(In reply to comment #18)
> additional fixes for the translation. we hope to get the rest of the help
> section translated before 2.0.0.1/
Reuven, didn't I sent you the updated help section for 2.0?

Comment 20

[Tomer Cohen :tomer]

Axel: Will Hebrew be released with the other locales for the upcoming 2.0.0.1? 

Comment 21

[Reuven Gonen]

Attachment: he translation update

this is the help translation from Tomer, and some access keys fixes.

Comment 22

[Axel Hecht [:Pike]]

Comment on attachment 246151 [details] [diff] [review]
he translation update

[he] approval for landing a bunch of fixes for Hebrew, including a huge chunk for help.

tomer, did you try that code with my testing extension at http://people.mozilla.com/~axel/l10n/?

Regarding shipping, there still seems to be a whole slew of QA work going on, might be a good idea to do some litmus based testing, too.
In the end, we'll need you to "be done" with it, I can't make a call on that from looking at the patches.

Comment 23

[Axel Hecht [:Pike]]

Comment on attachment 246151 [details] [diff] [review]
he translation update

[he] approval for landing a bunch of fixes for Hebrew, including a huge chunk
for help.

Moving approval flag over from approval-l10n to the 1.8.1.1 one, which is the one we use for this release.

Comment 24

[Axel Hecht [:Pike]]

Adjusting whiteboard to "QA in progress", which I think is more up-to-date.

Comment 25

[Reed Loden [:reed]]

Even though attachment 246151 [details] [diff] [review] has landed, it seems there is more needed for full 1.8.1.1 support.

Comment 26

[Axel Hecht [:Pike]]

Clarification: I will do some further tests, and there will likely be some additional external QA effort next week to check that.

Comment 27

[Phil Ringnalda (:philor)]

Ping: looks like we're shipping he 2.0.0.4 - can this and the tracker it blocks be closed now?