nsDocumentFragment::QI should not fall through to nsGenericElement::QI

RESOLVED FIXED in mozilla15

Status

()

Core
DOM
RESOLVED FIXED
11 years ago
5 years ago

People

(Reporter: sicking, Assigned: Ms2ger)

Tracking

Trunk
mozilla15
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

It seems like a bad idea to let nsDocumentFragment::QI call into nsGenericElement::QI. This was done in bug 333078.

While many interfaces are shared between the two, they are from many perspectives very different. It's probably very easy to accidentally add an interface to nsGenericElement that we don't want nsDocumentFragment.
Assignee: general → nobody
QA Contact: ian → general
(Assignee)

Comment 1

5 years ago
(In reply to Jonas Sicking (:sicking) from comment #0)
> It's probably very easy to accidentally add an
> interface to nsGenericElement that we don't want nsDocumentFragment.

Indeed! We did in bug 690372.
Blocks: 690372
I can promise a quick review if you write a patch :)
(Assignee)

Comment 3

5 years ago
Created attachment 619658 [details] [diff] [review]
Patch v1

https://tbpl.mozilla.org/?tree=Try&rev=58c888edb5eb
Assignee: nobody → Ms2ger
Status: NEW → ASSIGNED
Attachment #619658 - Flags: review?(jonas)
Comment on attachment 619658 [details] [diff] [review]
Patch v1

Remove nsIDOMXPathNSResolver from there (it's also not on documents).

r=me with that.
Attachment #619658 - Flags: review?(jonas) → review+
(Assignee)

Updated

5 years ago
Depends on: 752045
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/812c0d95cd0d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.