Last Comment Bug 361460 - nsDocumentFragment::QI should not fall through to nsGenericElement::QI
: nsDocumentFragment::QI should not fall through to nsGenericElement::QI
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla15
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
: Andrew Overholt [:overholt]
Mentors:
Depends on: 752045
Blocks: 690372
  Show dependency treegraph
 
Reported: 2006-11-21 20:26 PST by Jonas Sicking (:sicking) No longer reading bugmail consistently
Modified: 2012-05-18 02:47 PDT (History)
10 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (1.87 KB, patch)
2012-04-30 13:10 PDT, :Ms2ger (⌚ UTC+1/+2)
jonas: review+
Details | Diff | Splinter Review

Description Jonas Sicking (:sicking) No longer reading bugmail consistently 2006-11-21 20:26:10 PST
It seems like a bad idea to let nsDocumentFragment::QI call into nsGenericElement::QI. This was done in bug 333078.

While many interfaces are shared between the two, they are from many perspectives very different. It's probably very easy to accidentally add an interface to nsGenericElement that we don't want nsDocumentFragment.
Comment 1 :Ms2ger (⌚ UTC+1/+2) 2012-04-30 01:11:24 PDT
(In reply to Jonas Sicking (:sicking) from comment #0)
> It's probably very easy to accidentally add an
> interface to nsGenericElement that we don't want nsDocumentFragment.

Indeed! We did in bug 690372.
Comment 2 Jonas Sicking (:sicking) No longer reading bugmail consistently 2012-04-30 01:15:38 PDT
I can promise a quick review if you write a patch :)
Comment 3 :Ms2ger (⌚ UTC+1/+2) 2012-04-30 13:10:23 PDT
Created attachment 619658 [details] [diff] [review]
Patch v1

https://tbpl.mozilla.org/?tree=Try&rev=58c888edb5eb
Comment 4 Jonas Sicking (:sicking) No longer reading bugmail consistently 2012-04-30 14:49:34 PDT
Comment on attachment 619658 [details] [diff] [review]
Patch v1

Remove nsIDOMXPathNSResolver from there (it's also not on documents).

r=me with that.
Comment 5 :Ms2ger (⌚ UTC+1/+2) 2012-05-18 02:47:38 PDT
https://hg.mozilla.org/mozilla-central/rev/812c0d95cd0d

Note You need to log in before you can comment on or make changes to this bug.