Closed
Bug 361460
Opened 19 years ago
Closed 13 years ago
nsDocumentFragment::QI should not fall through to nsGenericElement::QI
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: sicking, Assigned: Ms2ger)
References
Details
Attachments
(1 file)
|
1.87 KB,
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
It seems like a bad idea to let nsDocumentFragment::QI call into nsGenericElement::QI. This was done in bug 333078.
While many interfaces are shared between the two, they are from many perspectives very different. It's probably very easy to accidentally add an interface to nsGenericElement that we don't want nsDocumentFragment.
|
||
Updated•16 years ago
|
Assignee: general → nobody
QA Contact: ian → general
|
Assignee | |
Comment 1•13 years ago
|
||
(In reply to Jonas Sicking (:sicking) from comment #0)
> It's probably very easy to accidentally add an
> interface to nsGenericElement that we don't want nsDocumentFragment.
Indeed! We did in bug 690372.
Blocks: 690372
|
Reporter | |
Comment 2•13 years ago
|
||
I can promise a quick review if you write a patch :)
|
|
Assignee | |
Comment 3•13 years ago
|
||
|
|
Reporter | |
Comment 4•13 years ago
|
||
Comment on attachment 619658 [details] [diff] [review]
Patch v1
Remove nsIDOMXPathNSResolver from there (it's also not on documents).
r=me with that.
Attachment #619658 -
Flags: review?(jonas) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
|
||
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•