690372 - Give an IID to dom::Element

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Fabien Cazenave [:kaze]]

We want to use nsCOMPtr<dom::Element> instead of nsCOMPtr<nsIDOMElement> in a few cases, e.g. for bug 684187.

Comment 1

[Fabien Cazenave [:kaze]]

Attachment: patch proposal

Comment 2

[(no longer active)]

Comment on attachment 563431 [details] [diff] [review]
patch proposal

Review of attachment 563431 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/public/Element.h
@@ +204,5 @@
>  
>    nsEventStates mState;
>  };
>  
> +NS_DEFINE_STATIC_IID_ACCESSOR(Element, NS_ELEMENT_IID)

I _think_ this should go into a cpp file.  nsGenericElement.cpp sounds like a good choice.

Comment 3

[Boris Zbarsky [:bzbarsky]]

No, that typically goes in the header (e.g. see nsINode.h).

Comment 4

[(no longer active)]

Comment on attachment 563431 [details] [diff] [review]
patch proposal

Right!  Sorry :-)

Comment 5

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5336c87067f7

Comment 6

[Matt Brubeck (:mbrubeck)]

Sorry, I backed this out on inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/d1b5c48c22c7

because of crashes in test_fullscreen-api.html: https://tbpl.mozilla.org/php/getParsedLog.php?id=6632003&tree=Mozilla-Inbound

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

http://mxr.mozilla.org/mozilla-central/source/content/base/src/nsDocument.cpp#8633

(Which I just happen to have a fix for in bug 688547)

Comment 8

[Fabien Cazenave [:kaze]]

Attachment: patch proposal

(adding NS_INTERFACE_MAP_ENTRY)

This passes test_fullscreen-api.html here (Ubuntu 11.10).

Comment 9

[(no longer active)]

Comment on attachment 568041 [details] [diff] [review]
patch proposal

Ah, good catch!

Have this gone through try?

Comment 10

[Fabien Cazenave [:kaze]]

https://tbpl.mozilla.org/?tree=Try&rev=5230666d62db

The tests on Windows are not significant on this page (“infrastructure exception”). Anyway, there’s a fresh tbpl for bug 684187 which includes this patch: https://tbpl.mozilla.org/?tree=Try&rev=907654f23f5e

Comment 11

[(no longer active)]

Has this landed?  It seems like this patch is not in yet.  In that case, what are we waiting on?

Comment 12

[Mounir Lamouri (:mounir)]

(In reply to Ehsan Akhgari [:ehsan] from comment #11)
> Has this landed?  It seems like this patch is not in yet.  In that case,
> what are we waiting on?

It's in inbound.

Comment 13

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/35b60f8565a7