361642 - Lightning: Printing fails if calendar view was not shown before

Status: VERIFIED FIXED

(Calendar :: Printing, defect)

Description

[Stefan Sitter [:ssitter]]

Lightning: Printing fails if calendar view was not shown before

Steps to Reproduce:
1. Start Thunderbird. Do _not_ switch to calendar view!
2. Select 'Calendar->Print Calendar...' command

Actual Results:
Print preview dialog is displayed but preview area shows nothing. The drop down menu for print layout selection is empty. JavaScript console shows:

  Error: theView.startDay has no properties
  Source File: chrome://calendar/content/printDialog.js Line: 53

Closing the dialog results in console error:

  Error: gTempFile has no properties
  Source File: chrome://calendar/content/printDialog.js Line: 88

Expected Results:
Print preview dialog is shown and working correctly.

Additional Information:
No regression like the similar Bug 360821, the error already happens with the first Lightning build that has Printing enabled:
Fails using Thunderbird/1.5.0.8 (20061122) + Lightning/0.4a1 (2006103107)
Fails using Thunderbird/1.5.0.8 (20061122) + Lightning/0.4a1 (2006112205)

Comment 1

[Joey Minta]

Attachment: untested patch

Untested patch that should fix things here.  Whenever I get around to getting a new lightning tree and confirming that this actually does fix stuff, I'll ask for review.

Comment 2

[Daniel Boelzle [:dbo]]

I would prefer to actually disable the "current-view" and "selection" radios if no view is present. Did that in https://bugzilla.mozilla.org/attachment.cgi?id=249253.

Comment 3

[Daniel Boelzle [:dbo]]

checked in with fix for bug 351957.

Comment 4

[Stefan Sitter [:ssitter]]

Verified using Thunderbird/1.5.0.9 (20061207) + Lightning/0.4a1 (2007022303). Printing for custom date range is possible, all other options are disabled.