Some valid .url files fail to open properly

RESOLVED FIXED in Camino1.5

Status

Camino Graveyard
General
--
minor
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Wevah, Assigned: Wevah)

Tracking

({fixed1.8.0.9, fixed1.8.1.1})

unspecified
Camino1.5
PowerPC
Mac OS X
fixed1.8.0.9, fixed1.8.1.1

Details

Attachments

(2 attachments)

1.69 KB, patch
max
: review+
Stuart Morgan
: superreview+
Details | Diff | Splinter Review
2.55 KB, patch
froodian (Ian Leue)
: review+
Smokey Ardisson (offline for a while; not following bugs - do not email)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

11 years ago
Valid .url files without [InternetShortcut] as the first non-empty line, or without URL=foo as the line following fail to open properly.

Patch coming.

(Ref: http://forums.mozillazine.org/viewtopic.php?p=2619487)
(Assignee)

Updated

11 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

11 years ago
We also will open invalid .url files where the URL= line is in another []'d section after the [InternetShortcut] one.
(Assignee)

Comment 2

11 years ago
Created attachment 246571 [details] [diff] [review]
Robustification patch v1
Comment on attachment 246571 [details] [diff] [review]
Robustification patch v1

r=me on the code, though I didn't test it.
Attachment #246571 - Flags: superreview?(stuart.morgan)
Attachment #246571 - Flags: review+

Comment 4

11 years ago
Nominating for 1.0.4 as this seems fairly harmless. Also fixing version and severity, and targeting for 1.1.

cl
Severity: trivial → minor
Flags: camino1.0.4?
Target Milestone: --- → Camino1.1
Version: Trunk → unspecified

Updated

11 years ago
Attachment #246571 - Flags: superreview?(stuart.morgan) → superreview+

Comment 5

11 years ago
Checked in on trunk and MOZILLA_1_8_BRANCH with minor style changes. Thanks!
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.1.1
Resolution: --- → FIXED
Ditto on this one; needs a 1.8.0branch patch.
(Assignee)

Comment 7

11 years ago
Created attachment 248434 [details] [diff] [review]
1.8.0 branch version

I removed Josh's byline also, which was already done on trunk.
(Assignee)

Updated

11 years ago
Attachment #248434 - Flags: review?(stridey)
Comment on attachment 248434 [details] [diff] [review]
1.8.0 branch version

I tested this, and it works as expected (within the confines of bug 363654 on the 1.8.0 branch and bug 363633 everywhere).
Attachment #248434 - Flags: review+
Flags: camino1.0.4? → camino1.0.4+

Comment 9

11 years ago
Comment on attachment 248434 [details] [diff] [review]
1.8.0 branch version

r=me.  Since the differences are redonkulous, foregoing a second sr.  If
anybody disagrees, they should speak up before I get to checkins.
Attachment #248434 - Flags: review?(stridey) → review+

Updated

11 years ago
Whiteboard: [Needs Checkin 1.8.0branch]

Comment 10

11 years ago
Checked in on 1.8.0branch (forgot bug number in checkin comment, search for "robustification")
Keywords: fixed1.8.0.9
Whiteboard: [Needs Checkin 1.8.0branch]
You need to log in before you can comment on or make changes to this bug.