Valid .url files without [InternetShortcut] as the first non-empty line, or without URL=foo as the line following fail to open properly. Patch coming. (Ref: http://forums.mozillazine.org/viewtopic.php?p=2619487)
We also will open invalid .url files where the URL= line is in another 'd section after the [InternetShortcut] one.
Comment on attachment 246571 [details] [diff] [review] Robustification patch v1 r=me on the code, though I didn't test it.
Nominating for 1.0.4 as this seems fairly harmless. Also fixing version and severity, and targeting for 1.1. cl
Severity: trivial → minor
Target Milestone: --- → Camino1.1
Version: Trunk → unspecified
Attachment #246571 - Flags: superreview?(stuart.morgan) → superreview+
Checked in on trunk and MOZILLA_1_8_BRANCH with minor style changes. Thanks!
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Ditto on this one; needs a 1.8.0branch patch.
Created attachment 248434 [details] [diff] [review] 1.8.0 branch version I removed Josh's byline also, which was already done on trunk.
Comment on attachment 248434 [details] [diff] [review] 1.8.0 branch version I tested this, and it works as expected (within the confines of bug 363654 on the 1.8.0 branch and bug 363633 everywhere).
Attachment #248434 - Flags: review+
Flags: camino1.0.4? → camino1.0.4+
Comment on attachment 248434 [details] [diff] [review] 1.8.0 branch version r=me. Since the differences are redonkulous, foregoing a second sr. If anybody disagrees, they should speak up before I get to checkins.
Attachment #248434 - Flags: review?(stridey) → review+
Checked in on 1.8.0branch (forgot bug number in checkin comment, search for "robustification")
Whiteboard: [Needs Checkin 1.8.0branch]
You need to log in before you can comment on or make changes to this bug.