361838 - Some valid .url files fail to open properly

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Wevah (Nate Weaver)]

Valid .url files without [InternetShortcut] as the first non-empty line, or without URL=foo as the line following fail to open properly.

Patch coming.

(Ref: http://forums.mozillazine.org/viewtopic.php?p=2619487)

Comment 1

[Wevah (Nate Weaver)]

We also will open invalid .url files where the URL= line is in another []'d section after the [InternetShortcut] one.

Comment 2

[Wevah (Nate Weaver)]

Attachment: Robustification patch v1

Comment 3

[Maximilian Ruderburg [:max] (Arctic Revolution)]

Comment on attachment 246571 [details] [diff] [review]
Robustification patch v1

r=me on the code, though I didn't test it.

Comment 4

[Chris Lawson (gone)]

Nominating for 1.0.4 as this seems fairly harmless. Also fixing version and severity, and targeting for 1.1.

cl

Comment 5

[Stuart Morgan]

Checked in on trunk and MOZILLA_1_8_BRANCH with minor style changes. Thanks!

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Ditto on this one; needs a 1.8.0branch patch.

Comment 7

[Wevah (Nate Weaver)]

Attachment: 1.8.0 branch version

I removed Josh's byline also, which was already done on trunk.

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 248434 [details] [diff] [review]
1.8.0 branch version

I tested this, and it works as expected (within the confines of bug 363654 on the 1.8.0 branch and bug 363633 everywhere).

Comment 9

[froodian (Ian Leue)]

Comment on attachment 248434 [details] [diff] [review]
1.8.0 branch version

r=me.  Since the differences are redonkulous, foregoing a second sr.  If
anybody disagrees, they should speak up before I get to checkins.

Comment 10

[froodian (Ian Leue)]

Checked in on 1.8.0branch (forgot bug number in checkin comment, search for "robustification")