361993 - Closing edit task menu doesn't save changes

Status: RESOLVED WORKSFORME

(Calendar :: Lightning Only, enhancement)

Description

[Nathan]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0
Build Identifier: Thunderbird version 1.5.0.8 (20061025) (and Lightning 0.3 [build 2006100618])

When one has made changes to the task description in the Edit Task window, and then clicks on the upper right close button (the X), the window closes without saving the changes. I understand that the proper usage is to click OK to save the changes, but it is surprisingly easy to just hit the close button instead. (I've now done it several times.) It is fairly standard for applications to provide a warning when one tries to close a window with unsaved data (and to provide an opportunity for saving the changes). I think it would be a good idea for Lightning to do the same.

Reproducible: Always

Steps to Reproduce:
1. double-click on a task to open edit menu
2. make changes to task description
3. click on close button (X)

Actual Results:  
the changes to the task description were gone

Expected Results:  
opened a dialog warning me that I have not yet saved the changes, and giving me the opportunity to do so.

Comment 2

[Omar Bajraszewski]

(In reply to comment #1)
> *** Bug 364387 has been marked as a duplicate of this bug. ***
> 

My report is about prototype- it's not the same.

Comment 3

[Omar Bajraszewski]

(In reply to comment #0)
> User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1)
> Gecko/20061010 Firefox/2.0
> Build Identifier: Thunderbird version 1.5.0.8 (20061025) (and Lightning 0.3
> [build 2006100618])
> Steps to Reproduce:
> 1. double-click on a task to open edit menu
> 2. make changes to task description
> 3. click on close button (X)
> 
> Actual Results:  
> the changes to the task description were gone
> 
> Expected Results:  
> opened a dialog warning me that I have not yet saved the changes, and giving me
> the opportunity to do so.
> 

It works now with latest nightly build 2007091903--->Fixed

Comment 4

[Stefan Sitter [:ssitter]]

(In reply to comment #3)
We only mark bugs as fixed if a patch has been checked into the tree -> WFM