362128 - Mingw build error in ../toolkit/airbag/nsAirbagExceptionHandler.cpp

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[Bengt-Erik Soderstrom]

Ater applying the fixes proposed in bug 358023, I had some hope that now, finally the Mingw build issues were solved. But no, there is more. It looks like  DbgHelp.h is missing:

Building deps for /cygdrive/d/mozilla/mozilla/toolkit/airbag/nsAirbagExceptionHa
ndler.cpp
/cygdrive/d/mozilla/mozilla/build/cygwin-wrapper g++ -mno-cygwin -o nsAirbagExce
ptionHandler.o -c  -DUNICODE -D_UNICODE -DMOZILLA_INTERNAL_API -DOSTYPE=\"WINNT5
.1\" -DOSARCH=\"WINNT\" -DBUILD_ID=2006112814 -I/cygdrive/d/mozilla/mozilla/tool
kit/airbag/airbag/src -I../../dist/include/xpcom -I../../dist/include/string -I.
./../dist/include   -I../../dist/include/airbag -I../../dist/include/nspr  -DMOZ
_PNG_READ -DPNG_NO_MMX_CODE -DMOZ_PNG_WRITE  -I../../dist/sdk/include       -fno
-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Wcast-align -Woverload
ed-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-long-long -
pedantic -mms-bitfields -pipe  -DNDEBUG -DTRIMMED -O   -DWINVER=0x501 -D_WIN32_W
INNT=0x501 -DX_DISPLAY_MISSING=1 -DMOZILLA_VERSION=\"1.9a1\" -DMOZILLA_VERSION_U
=1.9a1 -DHAVE_SNPRINTF=1 -D_WINDOWS=1 -D_WIN32=1 -DWIN32=1 -DXP_WIN=1 -DXP_WIN32
=1 -DHW_THREADS=1 -DSTDC_HEADERS=1 -DWIN32_LEAN_AND_MEAN=1 -DNO_X11=1 -D_X86_=1
-DD_INO=d_ino -DSTDC_HEADERS=1 -DHAVE_DIRENT_H=1 -DHAVE_GETOPT_H=1 -DHAVE_MEMORY
_H=1 -DHAVE_UNISTD_H=1 -DHAVE_MALLOC_H=1 -DHAVE_LIBM=1 -DNO_X11=1 -DMMAP_MISSES_
WRITES=1 -DHAVE_STRERROR=1 -DHAVE_SNPRINTF=1 -DHAVE_MEMMOVE=1 -DHAVE_RINT=1 -DVA
_COPY=va_copy -DHAVE_VA_COPY=1 -DMOZ_EMBEDDING_LEVEL_DEFAULT=1 -DMOZ_EMBEDDING_L
EVEL_BASIC=1 -DMOZ_EMBEDDING_LEVEL_MINIMAL=1 -DMOZ_PHOENIX=1 -DMOZ_BUILD_APP=bro
wser -DMOZ_XUL_APP=1 -DMOZ_DEFAULT_TOOLKIT=\"cairo-windows\" -DMOZ_THEBES=1 -DMO
Z_CAIRO_GFX=1 -DMOZ_DISTRIBUTION_ID=\"org.mozilla\" -DOJI=1 -DIBMBIDI=1 -DMOZ_VI
EW_SOURCE=1 -DMOZ_XPINSTALL=1 -DMOZ_JSLOADER=1 -DNS_PRINTING=1 -DNS_PRINT_PREVIE
W=1 -DMOZ_NO_XPCOM_OBSOLETE=1 -DMOZ_XTF=1 -DMOZ_AIRBAG=1 -DMOZ_MATHML=1 -DMOZ_EN
ABLE_CANVAS=1 -DMOZ_SVG=1 -DMOZ_SVG_FOREIGNOBJECT=1 -DMOZ_UPDATE_CHANNEL=default
 -DMOZ_FEEDS=1 -DMOZ_STORAGE=1 -DMOZ_SAFE_BROWSING=1 -DMOZ_URL_CLASSIFIER=1 -DMO
Z_LOGGING=1 -DHAVE___CXA_DEMANGLE=1 -DMOZ_USER_DIR=\"Mozilla\" -DHAVE_STDINT_H=1
 -DHAVE_INTTYPES_H=1 -DHAVE_UINT64_T=1 -DMOZ_XUL=1 -DMOZ_PROFILELOCKING=1 -DMOZ_
RDF=1 -DMOZ_MORK=1 -DMOZ_MORKREADER=1 -DMOZ_DLL_SUFFIX=\".dll\" -DJS_THREADSAFE=
1 -DMOZILLA_LOCALE_VERSION=\"1.9a1\" -DMOZILLA_REGION_VERSION=\"1.9a1\" -DMOZILL
A_SKIN_VERSION=\"1.8\"  -D_MOZILLA_CONFIG_H_ -DMOZILLA_CLIENT /cygdrive/d/mozill
a/mozilla/toolkit/airbag/nsAirbagExceptionHandler.cpp
In file included from d:/mozilla/mozilla/toolkit/airbag/nsAirbagExceptionHandler
.cpp:45:
d:/mozilla/mozilla/toolkit/airbag/airbag/src/client/windows/handler/exception_ha
ndler.h:63:21: DbgHelp.h: No such file or directory
In file included from d:/mozilla/mozilla/toolkit/airbag/nsAirbagExceptionHandler
.cpp:45:
d:/mozilla/mozilla/toolkit/airbag/airbag/src/client/windows/handler/exception_ha
ndler.h:65: warning: ignoring #pragma warning
d:/mozilla/mozilla/toolkit/airbag/airbag/src/client/windows/handler/exception_ha
ndler.h:67: warning: ignoring #pragma warning
In file included from d:/mozilla/mozilla/toolkit/airbag/nsAirbagExceptionHandler
.cpp:45:
d:/mozilla/mozilla/toolkit/airbag/airbag/src/client/windows/handler/exception_ha
ndler.h:114: error: `MINIDUMP_TYPE' has not been declared
d:/mozilla/mozilla/toolkit/airbag/airbag/src/client/windows/handler/exception_ha
ndler.h:115: error: expected `,' or `...' before "ExceptionParam"
d:/mozilla/mozilla/toolkit/airbag/airbag/src/client/windows/handler/exception_ha
ndler.h:117: error: ISO C++ forbids declaration of `DumpType' with no type
d:/mozilla/mozilla/toolkit/airbag/airbag/src/client/windows/handler/exception_ha
ndler.h:117: error: ISO C++ forbids declaration of `PMINIDUMP_EXCEPTION_INFORMAT
ION' with no type
d:/mozilla/mozilla/toolkit/airbag/airbag/src/client/windows/handler/exception_ha
ndler.h:203: warning: ignoring #pragma warning
make[5]: *** [nsAirbagExceptionHandler.o] Error 1
make[5]: Leaving directory `/cygdrive/d/mozilla/mozilla/object-mingw/toolkit/air
bag'
make[4]: *** [libs] Error 2
make[4]: Leaving directory `/cygdrive/d/mozilla/mozilla/object-mingw/toolkit'
make[3]: *** [libs_tier_toolkit] Error 2
make[3]: Leaving directory `/cygdrive/d/mozilla/mozilla/object-mingw'
make[2]: *** [tier_toolkit] Error 2
make[2]: Leaving directory `/cygdrive/d/mozilla/mozilla/object-mingw'
make[1]: *** [alldep] Error 2
make[1]: Leaving directory `/cygdrive/d/mozilla/mozilla/object-mingw'
make: *** [alldep] Error 2

DbgHelp.h is part of the Visual C SDK where it is found in ../sdk/include.
The obvious thing would be to copy DbgHelp.h into mingw's include directory or      
add sdk/include into the path. But then other errors occur:


In file included from d:/mozilla/mozilla/toolkit/airbag/airbag/src/client/window
s/handler/exception_handler.h:63,
                 from d:/mozilla/mozilla/toolkit/airbag/nsAirbagExceptionHandler
.cpp:45:
d:/mozilla/mingw/bin/../lib/gcc/mingw32/3.4.5/../../../../include/DbgHelp.h:67:
error: `PIMAGE_NT_HEADERS32' does not name a type
d:/mozilla/mingw/bin/../lib/gcc/mingw32/3.4.5/../../../../include/DbgHelp.h:67:
error: extra semicolon
In file included from d:/mozilla/mozilla/toolkit/airbag/airbag/src/client/window
s/handler/exception_handler.h:63,
                 from d:/mozilla/mozilla/toolkit/airbag/nsAirbagExceptionHandler
.cpp:45:
d:/mozilla/mingw/bin/../lib/gcc/mingw32/3.4.5/../../../../include/DbgHelp.h:2266
: error: expected constructor, destructor, or type conversion before '(' token
In file included from d:/mozilla/mozilla/toolkit/airbag/nsAirbagExceptionHandler
.cpp:45:
d:/mozilla/mozilla/toolkit/airbag/airbag/src/client/windows/handler/exception_ha
ndler.h:65: warning: ignoring #pragma warning
d:/mozilla/mozilla/toolkit/airbag/airbag/src/client/windows/handler/exception_ha
ndler.h:67: warning: ignoring #pragma warning
In file included from d:/mozilla/mozilla/toolkit/airbag/nsAirbagExceptionHandler
.cpp:45:
d:/mozilla/mozilla/toolkit/airbag/airbag/src/client/windows/handler/exception_ha
ndler.h:203: warning: ignoring #pragma warning
make[5]: *** [nsAirbagExceptionHandler.o] Error 1
make[5]: Leaving directory `/cygdrive/d/mozilla/mozilla/object-mingw/toolkit/air
bag'
make[4]: *** [libs] Error 2
make[4]: Leaving directory `/cygdrive/d/mozilla/mozilla/object-mingw/toolkit'
make[3]: *** [libs_tier_toolkit] Error 2
make[3]: Leaving directory `/cygdrive/d/mozilla/mozilla/object-mingw'
make[2]: *** [tier_toolkit] Error 2
make[2]: Leaving directory `/cygdrive/d/mozilla/mozilla/object-mingw'
make[1]: *** [alldep] Error 2
make[1]: Leaving directory `/cygdrive/d/mozilla/mozilla/object-mingw'
make: *** [alldep] Error 2


It looks like there's more work to do before Mingw  can be used again...

Comment 1

[Benjamin Smedberg]

I don't think we want to try to make airbag work with mingw. Please use --disable-airbag

Comment 2

[cls]

Attachment: v1.0

Since airbag is a new addition & highly platform specific, it should only be enabled for the platform it supports.

Comment 3

[cls]

Checking in configure;
/cvsroot/mozilla/configure,v  <--  configure
new revision: 1.1757; previous revision: 1.1756
done
Checking in configure.in;
/cvsroot/mozilla/configure.in,v  <--  configure.in
new revision: 1.1748; previous revi