362424 - Sometimes the text in the combobox is left aligned when it should be right aligned

Status: RESOLVED DUPLICATE of bug 331052

(Core :: Layout: Form Controls, defect)

Description

[Martijn Wargers (dead)]

On the site there is a combobox, sometimes the text in it is left aligned, when it should be right aligned.
I'll attach a testcase that shows the bug.
This is a regression on trunk.
This regressed between 2006-06-15 and 2006-05-16 (although it wasn't entirely correct before that either):
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-06-15+06&maxdate=2006-06-16+07&cvsroot=%2Fcvsroot
Not really sure which patch could have caused this.

But the bug doesn't happen on reflow branch, so maybe it doesn't matter that much at all. However the reflow branch has a bug of its own. I'll attach a picture of what kind of combobox I see with the reflow branch build.

Comment 1

[Martijn Wargers (dead)]

Attachment: testcase

Comment 2

[Martijn Wargers (dead)]

Attachment: screenshot of what I see in the reflow branch

This is what I see in the reflow branch, the drop down button is slightly on the wrong place for me.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Actually, I get the bug in a 2006-06-15-01 build, but not a 2006-06-14-01 one.  Probably regressed from bug 328168.

The reflow branch issue is probably due to the use of GetScrollBarDimensions and the use of double-width scrollbars here....  I'd love to step through the code with you sometime to figure out what's going on, but that should probably be a separate bug.

Comment 4

[Uri Bernstein]

*** This bug has been marked as a duplicate of 331052 ***

Comment 5

[Boris Zbarsky [:bzbarsky]]

Please make sure a bug is filed about the reflow branch issue, ok?

Comment 6

[Martijn Wargers (dead)]

(In reply to comment #5)
> Please make sure a bug is filed about the reflow branch issue, ok?

I filed bug 362485 for it.