362485 - [reflow branch]The drop down button is slightly in the wrong spot in the combobox

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Martijn Wargers (dead)]

This is a follow-up from bug 362424.

Comment from Boris:
> The reflow branch issue is probably due to the use of GetScrollBarDimensions
> and the use of double-width scrollbars here....  I'd love to step through the
> code with you sometime to figure out what's going on, but that should probably
> be a separate bug.

(the testcase is not completely minimised since it was made for bug 362424, but that should not really matter)

This is a screenshot of what I see in my reflow branch build:
https://bugzilla.mozilla.org/attachment.cgi?id=247123

Comment 1

[Boris Zbarsky [:bzbarsky]]

Catch me on IRC sometime when you have time to mess with this?

Comment 2

[Martijn Wargers (dead)]

Attachment: added printfs

Ok, I added these printfs, and loaded a testcase with auto width combobox, these are the results:
buttonWidth: 480
aReflowState.mComputedWidth: 3375
aReflowState.parentReflowState->mComputedWidth: 3975
aReflowState.mComputedBorderPadding.LeftRight(): 60
mComboBox->mDisplayWidth: 3495
aPresContext->ScaledPixelsToTwips(): 15.000000

Comment 3

[Martijn Wargers (dead)]

Attachment: testcase, that I used

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Possible patch

Martijn, does this help?  Seems to me like it should...

Comment 5

[Martijn Wargers (dead)]

Yes, that fixes it, r+ from me ;)

Comment 6

[Boris Zbarsky [:bzbarsky]]

Checked in on the branch.