362478 - Thunderbird (WINNT 5.2 tb-win32-tbox Depend) compiled with winver 0x400

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

According to logs -DWINVER=0x400 -D_WIN32_WINNT=0x400 are used.
Is there any reason for this?

Comment 1

[Scott MacGregor]

I think these build flags can be removed now that the trunk Thunderbird build machine is using VS8.

Comment 2

[:Gijs (he/him)]

This was one of the reasons my checkin for bug 366337 broke. I would really appreciate it if this could be fixed, as it will cause problems for that checkin otherwise. :-)

Comment 3

[:Gijs (he/him)]

Attachment: Patch

Per:
[23:58:15]	<sayrer>	looks like it makes for -D_WIN32_WINNT=0x400
[23:58:38]	<sayrer>	but you need _WIN32_WINNT=0x0500

Comment 4

[:Gijs (he/him)]

Comment on attachment 251971 [details] [diff] [review]
Patch

<rhelmer>	Hannibal: can you r? mscott as well?

Comment 5

[Scott MacGregor]

Comment on attachment 251971 [details] [diff] [review]
Patch

can't we just remove this winver string altogether? Do we list it in the firefox trunk win32 build?

Comment 6

[Robert Helmer [:rhelmer]]

(In reply to comment #5)
> (From update of attachment 251971 [details] [diff] [review])
> can't we just remove this winver string altogether? Do we list it in the
> firefox trunk win32 build? 

This patch is for trunk; we do not list this on the 1.8 or 1.8.0 branches though.

Comment 7

[:Gijs (he/him)]

Attachment: Patch: Remove line entirely

Fx trunk doesn't have it either. So then perhaps this is better.

Comment 8

[Scott MacGregor]

Comment on attachment 251978 [details] [diff] [review]
Patch: Remove line entirely

Rob's review is the one that really matters though :)

Comment 9

[:Gijs (he/him)]

Cool! Rob, can I check this in myself (at some time when there are build people around) and will that automagically update the tinderbox? Or are things more complicated than that?

Comment 10

[Robert Helmer [:rhelmer]]

(In reply to comment #9)
> Cool! Rob, can I check this in myself (at some time when there are build people
> around) and will that automagically update the tinderbox? Or are things more
> complicated than that?

Go ahead and check in, it will be automatically pulled by tinderbox.

Comment 11

[:Gijs (he/him)]

Checking in mozilla/tools/tinderbox-configs/thunderbird/win32/mozconfig;
/cvsroot/mozilla/tools/tinderbox-configs/thunderbird/win32/mozconfig,v  <--  mozconfig
new revision: 1.4; previous revision: 1.3
done

The build has since cycled succesfully with the new mozconfig.