362572 - When sans-serif is default, hint text is truncated

Status: RESOLVED FIXED

(Camino Graveyard :: Preferences, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

In font prefs, when sans-serif is the default for proportional fonts for the langGroup (like Japanese), the "Proportional" hint text is cut off.

This was OK in 1.0.x, so I suspect our prefs cleanup broke this.

Comment 1

[froodian (Ian Leue)]

Attachment: Appearance.nib

Oops. >:-(

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 247250 [details]
Appearance.nib

We need to re-center the items; proportional (sans-serif) looks smashed up against the wall now :(

Comment 3

[froodian (Ian Leue)]

Attachment: Appearance.nib

This is still a bit further left than we had it in 1.0.x, 'cause it just looks so damn lopsided when the text is "serif".  I tried to equalize the imbalance, so both ways look equally bad. ;)

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 247296 [details]
Appearance.nib

Looks OK to me, and much better than before.

r=ardissone, though you might consider shrinking the bounding box of "Proportional" to the actual width used by "Proportional (sans-serif):" (edit it in temporarily).

Comment 5

[froodian (Ian Leue)]

Attachment: serif screenshot

Comment 6

[froodian (Ian Leue)]

Attachment: sans-serif screenshot

Comment 7

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 247296 [details]
Appearance.nib

rs=pink

Comment 8

[froodian (Ian Leue)]

Checked in on 1.8branch and trunk.