362609 - Change font of example label to match default proportional font type

Status: RESOLVED FIXED

(Camino Graveyard :: Preferences, defect)

Description

[froodian (Ian Leue)]

In the Appearance prefs we change the hint text for the Proportional font to match the default font type for the selected region.  However, we don't change the font of the hint text.  STR:

1. Choose fonts for Western
2. Observe the hint text "(like Times)", shown in Times
3. Change region popup to Japanese
4. Observe the hint text "(like Helvetica)", still shown in Times

We should flip the font back and forth to match the text.  I'm not sure how this works with l10n (do they change the text for the "example" font?).

Comment 1

[froodian (Ian Leue)]

Attachment: Patch

As I said, I don't know if this is fragile given l10n (or even just fragile on its own).

It'll also require a slight nib tweak to heighten the bounding box for the text, since Helvetica 13 is taller than Times 13.  This tweak will appear in the next nib for bug 362572.

Comment 2

[Stuart Morgan]

Comment on attachment 247295 [details] [diff] [review]
Patch

This looks reasonable to me. I'm not seeing why it would be l10n-fragile, since regardless of whether the hint text is localized, the font type should be right for the default, right?

Comment 3

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 247295 [details] [diff] [review]
Patch

rs=pink

Comment 4

[froodian (Ian Leue)]

Checked in on 1.8branch and trunk.

Comment 5

[Samuel Sidler (old account; do not CC)]

Moving fixed "1.2" bugs to 1.1 where they were really fixed. Filter on CaminoFixed1.1 for bugmail purposes.