Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Crash [@ nsIView::Destroy] on print preview

VERIFIED FIXED

Status

()

Core
Layout
--
critical
VERIFIED FIXED
11 years ago
6 years ago

People

(Reporter: Martijn Wargers (dead), Assigned: Bernd)

Tracking

(4 keywords)

Trunk
x86
Windows XP
crash, testcase, verified1.8.0.10, verified1.8.1.2
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [sg:moderate?], crash signature)

Attachments

(5 attachments, 1 obsolete attachment)

(Reporter)

Description

11 years ago
See upcoming testcases.
The unminimised testcase crashes on print preview. The minimised testcase crashes when closing print preview for me.
The unminimised testcase also crashes on reflow branch builds for me.
But the testcase don't crash on the latest 1.8 branch. It seems to be fixed somehow on the 1.8 branch between 2006-08-02 and 2006-08-03:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=MOZILLA_1_8_BRANCH&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-08-02+04&maxdate=2006-08-03+07&cvsroot=%2Fcvsroot
Maybe fixed somehow with the patch for bug 302911?
(Reporter)

Comment 1

11 years ago
Created attachment 247408 [details]
Minimised testcase
(Assignee)

Comment 3

11 years ago
This doesn't crash for me, can you produce a reflow log so that I can estimate what frames are involved.
(Reporter)

Comment 4

11 years ago
Created attachment 247481 [details]
logfile

This is the log from the moment when I opened up the unminimised testcase in print preview, until I closed print preview (in which I crash).
I hope it's useful.
(Assignee)

Comment 5

11 years ago
Martijn, is it possible to convert your test cases from pixel heights to page-break properties (http://www.w3.org/TR/REC-CSS2/page.html#page-breaks)? This would make them much more reliable.
(Assignee)

Comment 6

11 years ago
I get a couple of asserts with the unminimized testcase

###!!! ASSERTION: Allowed only one anonymous view between frames: 'ancestorView
== view->GetParent()->GetParent()', file d:/moz_src/mozilla/layout/generic/nsCon
tainerFrame.cpp, line 272
###!!! ASSERTION: Creating a circular frame list, this is very bad.: 'this != aN
extSibling', file d:\moz_src\mozilla\layout\generic\nsIFrame.h, line 677

could you please create minimized test cases for the asserts (bonus points if they work with the page-break properties ;-) )

(Reporter)

Comment 7

11 years ago
Created attachment 247517 [details]
Minimised testcase

(In reply to comment #5)
> Martijn, is it possible to convert your test cases from pixel heights to
> page-break properties (http://www.w3.org/TR/REC-CSS2/page.html#page-breaks)?
> This would make them much more reliable.

Ok, thanks, this allowed me to minimise the minimised testcase to this. I hope this one crashes for you when closing print preview, it does for me.
Attachment #247408 - Attachment is obsolete: true
(Reporter)

Comment 8

11 years ago
Created attachment 247521 [details]
testcase2

Testcase that gives the "###!!! ASSERTION: Allowed only one anonymous view between frames: 'ancestorView== view->GetParent()->GetParent()'" assertion.
It uses page-break-after: always; ==> 1st bonus point for me.
(Reporter)

Comment 9

11 years ago
Created attachment 247525 [details]
testcase3

No bonus points for this one.
This gives the "###!!! ASSERTION: Creating a circular frame list, this is very bad.:" on print preview for me.
It isn't as minimised as far as I could, but still quite a bit complicated.
(Assignee)

Comment 10

11 years ago
cool that works now very smooth to get lizard down to its knees
(Assignee)

Comment 11

11 years ago
Created attachment 247852 [details] [diff] [review]
patch

This is basically what you did 3.5 years ago for blocks
https://bugzilla.mozilla.org/show_bug.cgi?id=201767#c19
Assignee: nobody → bernd_mozilla
Status: NEW → ASSIGNED
Attachment #247852 - Flags: superreview?(roc)
Attachment #247852 - Flags: review?(roc)
(Assignee)

Comment 12

11 years ago
The patch fixes the crash, but the assert from testcase 3 is something different
(Assignee)

Comment 13

11 years ago
Testcase 3 should be split into a separate probably public bug as it has no views involved.
Attachment #247852 - Flags: superreview?(roc)
Attachment #247852 - Flags: superreview+
Attachment #247852 - Flags: review?(roc)
Attachment #247852 - Flags: review+
(Reporter)

Comment 14

11 years ago
(In reply to comment #13)
> Testcase 3 should be split into a separate probably public bug as it has no
> views involved.

Ok, I filed bug 363120 for that.

(Assignee)

Comment 15

11 years ago
fix checked in, we need this probably on every branch that is maintained
(Assignee)

Updated

11 years ago
Attachment #247852 - Flags: approval1.8.1.2?
Attachment #247852 - Flags: approval1.8.0.10?
Comment on attachment 247852 [details] [diff] [review]
patch

bug 362837
Attachment #247852 - Flags: approval1.8.1.2?
Attachment #247852 - Flags: approval1.8.1.2+
Attachment #247852 - Flags: approval1.8.0.10?
Attachment #247852 - Flags: approval1.8.0.10+
(Assignee)

Comment 17

11 years ago
fixed on branches on dec. 27th 2006
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.0.10, fixed1.8.1.2
Resolution: --- → FIXED
Whiteboard: [sg:moderate?]
(Reporter)

Comment 18

11 years ago
Verified fixed on the latest 1.8.0.x and latest 1.8.1 branch builds, no crash anymore when closing print preview on the testcases.
The latest trunk builds hang on print preview on certain testcases, I think that's what bug 363120 is basically about.
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.0.10, fixed1.8.1.2 → verified1.8.0.10, verified1.8.1.2
Group: security
Depends on: 372487
No longer depends on: 372487
Crash Signature: [@ nsIView::Destroy]
You need to log in before you can comment on or make changes to this bug.