363154 - [TB-3a1] Improper RSS Display After Todays(12/8/06) Auto-update

Status: RESOLVED FIXED

(MailNews Core :: Feed Reader, defect)

Description

[Nir]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0

After Installing Auto-update , when I restarted TB , found that RSS functionality is not working properly.
Please see the two screen shots ( attached )


Reproducible: Always

Comment 1

[Nir]

Attachment: Incorrect display of a new rss feed

Comment 2

[Nir]

Attachment: Incorrect display of an old rss feed

Please note that you must select 'Original HTML' in View > Message Body As to reproduce this problem

Comment 3

[Nir]

If i click on a rss feed just after opening TB-3a1 , only 'error message' that i have found in error console is 
"Error: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIIOService2.manageOfflineStatus]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: file:///usr/thunderbird/components/offlineStartup.js :: anonymous :: line 94"  data: no]
Source File: file:///usr/thunderbird/components/offlineStartup.js
Line: 94"

Comment 4

[Joe Sabash [:JoeS1]]

Seeing this in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061208 Thunderbird/3.0a1 ID:2006120803
Please change os to include win xp

Comment 5

[Nir]

Settings OS to All ( see Comment #4  )

Comment 6

[Nir]

Todays update doesn't improve the situation , same problem still persist . 

Comment 7

[Peter Lairo]

I'm getting that bug too (Tb version 3 alpha 1 (20061210), WinXP). New profile, never used RSS in Tb before (don't plan to either) (just for testing/confirming this bug).

REGRESSION

Comment 8

[Mike Cowperthwaite]

I'm not seeing this: TB 3a1-1210, Win2K.  I'm looking at a variety of feeds: Craig's List, MozillaZine, Rumbling Edge.

For those who do see this, is it seen on all feeds or just certain ones?

Comment 9

[Nir]

It happens on every feed in my TB-3a1 ( Linux version )

Comment 10

[Marcel Kneuer]

(In reply to comment #9)
> It happens on every feed in my TB-3a1 ( Linux version )

All feeds.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061210 Thunderbird/3.0a1 ID:2006121003

Comment 11

[Mike Stockman]

I see this only for RSS feeds that load a Web page for each article.

For feeds where the "Show the article summary instead of loading the web page" checkbox is turned *off* (the default), I see this bug as originally described.

For feeds that don't send the Web page, or for feeds where I have selected the "Show the article summary..." check box, this bug does not manifest.

Note that to test this, I could not just edit an existing feed in the Subscribe dialog and turn the checkbox on. That would have been too easy. (And that checkbox must apply only to subsequent entries, not existing ones, I guess.) I had to delete the feed and its folder from Tbird, then re-add it being sure to select the checkbox. Then the messages loaded correctly (without the Web page) and no split-screen effect was seen.

Comment 12

[Mike Cowperthwaite]

I'm not sure what changed, but I'm seeing it now with the same build as ref'd in comment 8.  Restarting TB doesn't make the problem go away.

Comment 13

[Scott MacGregor]

sounds like this could be caused by Bug 354345 which went into the trunk on the 7th and is now on the branch.

Comment 14

[Wladimir Palant]

No, bug 354345 is highly unlikely to have caused this, it didn't touch the display of messages in any way. I would rather suspect some Gecko changes that broke positioning.

Comment 15

[Phil Ringnalda (:philor)]

Your regression window is 2006-12-07 to 2006-12-08, trunk-only? That's when reflow landed, that'd be my first guess for an HTML rendering regression.

Comment 16

[Wladimir Palant]

Attachment: Testcase

Here is a testcase. Firefox 2 stretches the frame (green) to cover the whole window, current trunk builds on the other hand use the standard width. That's what is breaking the feed display in Thunderbird. And reflow landing is also my suspicion here.

Comment 17

[Wladimir Palant]

Removing dependency on bug 354345 since it clearly didn't cause this.

Comment 18

[Wladimir Palant]

Regression window in Firefox is 2006-12-07-04 to 2006-12-08-04.

Comment 19

[Magnus Melin [:mkmelin]]

*** Bug 363466 has been marked as a duplicate of this bug. ***

Comment 20

[Martijn Wargers (dead)]

*** Bug 363389 has been marked as a duplicate of this bug. ***

Comment 21

[Peter Reynolds]

I have this bug too.  It only affects the feeds that display a webpage, e.g. BBC News, and not ordinary blogs e.g. Blogger.

Comment 22

[Nir]

An additional information :

While trying to fix it myself , i have found a feed ( looks likes a cached feed ) that TB can shown in normal way .
But all other message in that rss folder are shown in same Improper way.

feed url : http://news.google.com/news/url?sa=T&ct=us/15-0&fd=R&url=http://www.geekzone.co.nz/content.asp%3Fcontentid%3D6897&cid=1111909766&ei=F3x-RdGLFLnSwgGzjcC8Dg
feed account : http://news.google.com/nwshp?oe=UTF-8&tab=wn&ned=us&topic=t&output=rss

Comment 23

[Nir]

Attachment: rss article that TB-3a1 can display properly

Comment 24

[Nir]

Attachment: Please note that Images are not shown in this article

Comment 25

[Nir]

Attachment: Message source of that rss feed

Comment 26

[Joe Sabash [:JoeS1]]

A common format for feeds is using an iframe with no width attribute.
We can test that this is the root of the problem in the reflow landing by
send the "feed" format in an email.
By adding the width 100% in the stylesheet and send via mail the feed displays
as intended.
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
  <meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
  <title></title>
  <title>In a Different Light</title>
  <base
 href="http://www.nasa.gov/multimedia/imagegallery/image_feature_715.html">
  <style type="text/css">
      
      body {
        margin: 0;
        border: none;
        padding: 0;
      }
      iframe {
        position: fixed;
        top: 0;
        right: 0;
        bottom: 0;
        left: 0;
        border: none;
        width: 100%;
      }

    </style>

</head>
<body bgcolor="#ffffff" text="#000000">
<br>
<iframe id="_mailrssiframe"
 src="http://www.nasa.gov/multimedia/imagegallery/image_feature_715.html">
Space Shuttle Discovery and its crew of seven astronauts lift off from
NASA's Kennedy Space Center, beginning the STS-116 mission to the
International Space Station </iframe>
<br>
</body>
</html>

Of course, RSS feed producers are not suddenly going to comply with the new
reflow branch needs so some workaround is going to be needed.

BTW the styles need not be in the head section to work correctly.

Comment 27

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Ah, so fixed/absolutely positioned iframes with left and right specified and auto width are treated like non-replaced elements rather than like replaced elements?  I wonder which other browsers do, and which the spec says to do.

In any case, I think the iframe stuff is related to the way Thunderbird converts RSS feeds to email messages, not the way RSS feeds are produced.

Comment 28

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch to fix the HTML messages generated from RSS feeds

So I think Thunderbird's RSS support was depending on a bug in Gecko, both per spec and based on our previous incompatibility with other browsers; see bug 363675 for details.

I think this patch should remove that dependence.  (I haven't tested it at all, though.)  However, it would only remove that dependence for new messages, not for messages already stored in mailboxes, so I don't think it's really sufficient, although if we got it checked in to branches it might be good enough by the time Thunderbird 3 came out.

However, a better solution might be to style the iframe by its id (_mailrssiframe) rather than in the message.

Comment 29

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch to correct the display of existing HTML email (with bad CSS) converted from RSS

Here's another possible patch, also completely untested, but which ought to fix the problem even for messages already converted from RSS to HTML.

Comment 30

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I tested both patches, and they do as I expect.  attachment 248487 [details] [diff] [review] fixes up new incoming messages from RSS but doesn't fix the display of messages already converted from RSS to email.  attachment 248489 [details] [diff] [review] does fix up the display of existing messages.

I think we should take attachment 248489 [details] [diff] [review] on the trunk, and, so that the HTML mailboxes we generate are more standards-conformant, take attachment 248487 [details] [diff] [review] on the trunk and branches as well.

Comment 31

[Scott MacGregor]

Comment on attachment 248489 [details] [diff] [review]
patch to correct the display of existing HTML email (with bad CSS) converted from RSS

thanks for tracking this down David.

Comment 32

[Scott MacGregor]

Comment on attachment 248487 [details] [diff] [review]
patch to fix the HTML messages generated from RSS feeds

approving this patch for the branch too.

Comment 33

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Both patches checked in to trunk.

Comment 34

[Nir]

(In reply to comment #33)
> Both patches checked in to trunk.
> 

Thanks David :)

Comment 35

[Mike Stockman]

Works for me, now, with today's trunk build version 3 alpha 1 (20061213). Thanks for fixing this.

Comment 36

[Peter Reynolds]

Yes, new nightly for 13th Dec fixes this for me too.  Thanks to all who worked on this!

Comment 37

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

attachment 248487 [details] [diff] [review] checked in to MOZILLA_1_8_BRANCH.

Comment 38

[Nir]

Seems to me that this patch ( today My TB-3a1 has auto updated itself and this rss display related bug doesn't occur anymore ) is not completely working or has resulted in another bug or problem.

Problem : even if i have set  'show the article summary instead of loading the web page' in  any rss folder ( right click on rss folder > subscribe > select that rss subscription > edit > select that option ), TB still use to show full rss article if view = original html

This settings was working before patch has been made available through update ( even during the time this bug remained unfixed )

(opening bug and attaching a screen shot)

Comment 39

[Nir]

Attachment: error in patch?

Comment 40

[Wladimir Palant]

Nir, please note that this setting is only applied to the articles you download after changing it, the articles that are already downloaded stay unaffected by the change. Is this the issue you are reporting?

Comment 41

[Nir]

(In reply to comment #40)
> Nir, please note that this setting is only applied to the articles you download
> after changing it, the articles that are already downloaded stay unaffected by
> the change. Is this the issue you are reporting?
> 

carefully checked again , My TB-31 has been updated at 8:39PM (Local time) yesterday ( it's 4:31am here right now )

two feed articles in the same rss folders are displayed to two view although I have set not to show full article

1st ( downloaded at 1:35am ) article is displayed with total content
2nd ( downloaded at 2:51am ) article is displayed as summary .

( attaching two screen shots )

is it possible it has occurred because of my own settings ? should i mark this bug as fixed as none other than me seems to have faced this ?
Thanks

Comment 42

[Nir]

Attachment: article that is showing full content

Comment 43

[Nir]

Attachment: article , showing only summery

Comment 44

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Sounds like comment 38 through comment 43 are about a different bug; marking this one as fixed again.

Comment 45

[Nir]

(In reply to comment #44)
> Sounds like comment 38 through comment 43 are about a different bug; marking
> this one as fixed again.
> 

David, is it possible that any other patch , made available through todays update can cause this problem? as i have mentioned before 'This settings was working before patch has been made available through update (even during the time this bug remained unfixed )'
Thanks

Comment 46

[Scott MacGregor]

(In reply to comment #45)
> (In reply to comment #44)
> > Sounds like comment 38 through comment 43 are about a different bug; marking
> > this one as fixed again.
> > 
> 
> David, is it possible that any other patch , made available through todays
> update can cause this problem? as i have mentioned before 'This settings was
> working before patch has been made available through update (even during the
> time this bug remained unfixed )'
> Thanks
> 

Please file a new bug. It sounds like it has nothing to do with this bug or fixing the layout issue David helped us with for RSS articles. Thanks!