This bug was spun off from bug 307387. See upcoming testcase. When the img has a scr with an invalid protocl, the height and width of the placeholder becomes 0, even when a width and height is set in css. This regressed on trunk between 2006-06-24 and 2006-06-27, I think it's a regression from bug 181860. On 1.8.0.x/1.8.1 branch, I'm seeing a regression in that the first img in the testcase doesn't show up the alternate text anymore, this regressed on the 1.8.1 branch between 2006-07-04 and 2006-07-06, which coincides with the landing of the patch for bug 181860.
Sicking, how come nsNoDataProtocolContentPolicy uses REJECT_SERVER? That's basically the return value that indicates content blocking is enabled for that site, so hide all traces of the image. Don't you want REJECT_REQUEST? That certainly fixes the issue on trunk for me...
Probably not a true blocker, but would be good to fix and may be easy
Created attachment 249072 [details] [diff] [review] Fix
11 years ago
Assignee: nobody → bzbarsky
OS: Windows XP → All
Priority: -- → P1
Hardware: PC → All
Summary: Regression with display of image placeholders when an invalid protocol is used → [FIX]Regression with display of image placeholders when an invalid protocol is used
Target Milestone: --- → mozilla1.9alpha
Comment on attachment 249072 [details] [diff] [review] Fix Thanks man
Fixed. Someone else may need to land this on branches...
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Comment on attachment 249072 [details] [diff] [review] Fix This is very safe and fixes a regression from a security fix.
11 years ago
Flags: blocking1.9? → in-testsuite?
Comment on attachment 249072 [details] [diff] [review] Fix Approved for both branches, a=jay for drivers.
Checked in on branches
Keywords: fixed220.127.116.11, fixed18.104.22.168
Verified fixed on 22.214.171.124 and 126.96.36.199 with Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:188.8.131.52pre) Gecko/2007011004 BonEcho/184.108.40.206pre and Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:220.127.116.11pre) Gecko/20070111 Firefox/18.104.22.168pre
Status: RESOLVED → VERIFIED
Keywords: fixed22.214.171.124, fixed126.96.36.199 → verified188.8.131.52, verified184.108.40.206
You need to log in before you can comment on or make changes to this bug.