[FIX]Regression with display of image placeholders when an invalid protocol is used

VERIFIED FIXED in mozilla1.9alpha1

Status

()

Core
Layout
P1
normal
VERIFIED FIXED
11 years ago
11 years ago

People

(Reporter: Martijn Wargers (dead), Assigned: bz)

Tracking

(4 keywords)

Trunk
mozilla1.9alpha1
regression, testcase, verified1.8.0.10, verified1.8.1.2
Points:
---
Bug Flags:
blocking1.8.1.2 +
blocking1.8.0.10 +
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

11 years ago
This bug was spun off from bug 307387.
See upcoming testcase.
When the img has a scr with an invalid protocl, the height and width of the placeholder becomes 0, even when a width and height is set in css.
This regressed on trunk between 2006-06-24 and 2006-06-27, I think it's a regression from bug 181860.

On 1.8.0.x/1.8.1 branch, I'm seeing a regression in that the first img in the testcase doesn't show up the alternate text anymore, this regressed on the 1.8.1 branch between 2006-07-04 and 2006-07-06, which coincides with the landing of the patch for bug 181860.
(Reporter)

Comment 1

11 years ago
Created attachment 248038 [details]
testcase
Sicking, how come nsNoDataProtocolContentPolicy uses REJECT_SERVER?  That's basically the return value that indicates content blocking is enabled for that site, so hide all traces of the image.  Don't you want REJECT_REQUEST?  That certainly fixes the issue on trunk for me...
Flags: blocking1.9?
Flags: blocking1.8.1.2?
Flags: blocking1.8.0.10?
Probably not a true blocker, but would be good to fix and may be easy
Flags: blocking1.8.1.2?
Flags: blocking1.8.1.2+
Flags: blocking1.8.0.10?
Flags: blocking1.8.0.10+
Created attachment 249072 [details] [diff] [review]
Fix
Attachment #249072 - Flags: superreview?(bugmail)
Attachment #249072 - Flags: review?(bugmail)
Assignee: nobody → bzbarsky
OS: Windows XP → All
Priority: -- → P1
Hardware: PC → All
Summary: Regression with display of image placeholders when an invalid protocol is used → [FIX]Regression with display of image placeholders when an invalid protocol is used
Target Milestone: --- → mozilla1.9alpha
Comment on attachment 249072 [details] [diff] [review]
Fix

Thanks man
Attachment #249072 - Flags: superreview?(bugmail)
Attachment #249072 - Flags: superreview+
Attachment #249072 - Flags: review?(bugmail)
Attachment #249072 - Flags: review+
Fixed.  Someone else may need to land this on branches...
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Comment on attachment 249072 [details] [diff] [review]
Fix

This is very safe and fixes a regression from a security fix.
Attachment #249072 - Flags: approval1.8.1.2?
Attachment #249072 - Flags: approval1.8.0.10?
Flags: blocking1.9? → in-testsuite?

Comment 8

11 years ago
Comment on attachment 249072 [details] [diff] [review]
Fix

Approved for both branches, a=jay for drivers.
Attachment #249072 - Flags: approval1.8.1.2?
Attachment #249072 - Flags: approval1.8.1.2+
Attachment #249072 - Flags: approval1.8.0.10?
Attachment #249072 - Flags: approval1.8.0.10+
Checked in on branches
Keywords: fixed1.8.0.10, fixed1.8.1.2
Verified fixed on 1.8.1.2 and 1.8.0.10 with  Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.2pre) Gecko/2007011004 BonEcho/2.0.0.2pre and Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.0.10pre) Gecko/20070111 Firefox/1.5.0.10pre
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.0.10, fixed1.8.1.2 → verified1.8.0.10, verified1.8.1.2
You need to log in before you can comment on or make changes to this bug.