363577 - Dragging link into BM Bar or BM Manager creates bookmark with URL as title instead of using link title

Status: RESOLVED FIXED

(Camino Graveyard :: Drag & Drop, defect)

Description

[John Bailey]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en; rv:1.9a1) Gecko/20061211 Camino/1.2+ (jcraig)
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en; rv:1.9a1) Gecko/20061211 Camino/1.2+

Dragging a link from the content area into BM Bar or BM Manager creates the bookmark with the URL being the title instead of the link's actual title.  This only happens on the trunk.  This does not happen if you drag the favicon from the URL field in the toolbar or from a tab.

Reproducible: Always

Steps to Reproduce:
1.Load google.com
2.Drag the "Advanced Search" link into BM Bar or Manager

Actual Results:  
The title or name of the bookmark is "http://www.google.com/advanced_search?hl=en"

Expected Results:  
The title or name of the bookmark is "Advanced Search"

I believe this regressed when cocoa drag-drop stuff landed, but I didn't verify that.  I tried to test this on Minefield, but that won't even let me drop links to bookmark them at all.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Could you do a little bit of checking and verify that Cocoa DnD broke this?  (Our bookmarking code is all our own, so Minefield isn't relevant here....)

Comment 2

[John Bailey]

10-25-06 build doesn't exhibit this, 10-27-06 does, so must be cocoa drag & drop.

Comment 3

[Chris Lawson (gone)]

When this is fixed, we need to make sure we do not re-introduce bug 296064.

Comment 4

[Chris Lawson (gone)]

cc'ing Josh, since he should know exactly what's going on here.

Comment 5

[Chris Lawson (gone)]

Josh, should the drag service be looking for more than just kUnicodeMime and kFileMime when in nsDragService::GetData? It looks to me like there isn't even any title data on the pasteboard for us to get any more, but it also looks like nsITransferable defines several other data types, one of which is kURLDescriptionMime, which is probably what we're interested in here.

Is it just a lack of implementation (read: you didn't get around to it when you wrote the Cocoa drag service, and no one else has stepped up to do it), or is there a specific reason that isn't supported?

It's probably safe to call this a Cocoa Widget bug, but I'm still not entirely convinced there won't be code changes necessary on Camino's end, so I'm sort of hesitant to move this until we know more.

Comment 6

[Chris Lawson (gone)]

A quick test of the latest Minefield nightly resulted in the desired behaviour for dragging links to the bookmarks bar or manager.

Comment 7

[Chris Lawson (gone)]

Further testing shows that somehow, Minefield is also somehow magically immune to bug 296064.

Comment 8

[Chris Lawson (gone)]

Apple's Pasteboard Peeker sample app shows that both apps are putting the same data on the clipboard, however. The mystery deepens.

Comment 9

[Stuart Morgan]

(In reply to comment #7)
> Further testing shows that somehow, Minefield is also somehow magically immune
> to bug 296064.

That's not magic. The failure there is in trying to convert back to an NSString, which Minefield doesn't try to do.

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: branch vs. Cocoa trunk drag content

As Chris notes, Cocoa drag is exporting a whole heck of a lot fewer types than Carbon used to, and prominently missing is urld, which we know from bug 296064 is what we (Camino) use to snag the link text and turn it into the bookmark title.

This is an example drag of the "[details]" link you seen in a Bugzilla comment with an attachment; I dragged tonight's branch nightly and the last trunk build I had on-hand (well after the switch) into PasteboardPeeker (which handles Carbon drags): http://developer.apple.com/samplecode/PasteboardPeeker/index.html

We probably don't need all of those old flavors, but we should at least be exporting urld (and/or urln; see bug 380582).

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I spun the underlying Cocoa widget bug off into bug 393609 so that chatter about Camino UI doesn't confuse the real issue widget folks need to fix ;)

Comment 12

[Chris Lawson (gone)]

Erm, despite the fact that this is superficially related to bookmarks, this is really a D&D issue ;)

Comment 13

[Josh Aas]

fixed by 393609