363578 - Date.UTC returns incorrect value if date is less than or equal to 0

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[nanto_vi (TOYAMA Nao)]

new Date(Date.UTC(2006, 0, 0)).getUTCDate() returns 1 (2006-01-01), but should return 31 (2005-12-31).  Other browsers (IE 7, Opera 9 and Safari 2) returns 31.

js/src/jsdate.c
594     /* if we got a 0 for 'date' (which is out of range)
595      * pretend it's a 1.  (So Date.UTC(1972, 5) works) */
596     if (array[2] < 1)
597         array[2] = 1;

Should check argc.  ECMA-262 3rd 15.9.4.3 says "3. If date is supplied use ToNumber(date); else use 1."

Comment 1

[jag (Peter Annema)]

Attachment: Fix bug in handling day-of-month value in UTC function

1) per 15.9.4.3 step 3, default day-of-month to 1 if missing
2) per 15.9.1.12 step 8, simply add the day-of-month value as-is
3) return NaN if any arg is NaN or infinite
4) use js_DoubleToInteger() instead of floor()

Comment 2

[jag (Peter Annema)]

See bug 379104 for the Rhino version of this

Comment 3

[jag (Peter Annema)]

Attachment: Same, but with most of the shared code factored out

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 263105 [details] [diff] [review]
Same, but with most of the shared code factored out

Remove that terribly outdated Win16 comment and r=mrbkap.

Comment 5

[jag (Peter Annema)]

Comment on attachment 263105 [details] [diff] [review]
Same, but with most of the shared code factored out

Seeking approval for 1.9. Whoever checks this in, don't forget to remove the Win16 comment.

Comment 6

[jag (Peter Annema)]

Attachment: Unbitrot after bug 385393 landed

Comment 7

[Brendan Eich [:brendan]]

jag: thanks for the fix, approved for 1.9!

/be

Comment 8

[Brendan Eich [:brendan]]

jag: forgot to add, please take assignment of this bug -- you fixed it.

/be

Comment 9

[Blake Kaplan (:mrbkap) (inactive)]

Checked in, finally. I'm really sorry for the long delay!

Comment 10

[Blake Kaplan (:mrbkap) (inactive)]

This should be fixed now.

Comment 11

[Bob Clary [:bc] (inactive)]

Checking in 15.9.4.3.js;
/cvsroot/mozilla/js/tests/ecma_3/Date/15.9.4.3.js,v  <--  15.9.4.3.js
initial revision: 1.1

Comment 12

[Bob Clary [:bc] (inactive)]

verified fixed 1.9.0 linux/mac*/windows.