379104 - new Date(2007,5,0) should reflect May 31, 2007, not June 1, 2007

Status: RESOLVED FIXED

(Rhino Graveyard :: Core, defect)

Description

[jag (Peter Annema)]

Attachment: Fix bug in handling day-of-month value in Date constructor, UTC function

There's a small bug in NativeData.java in how the Date constructor and the UTC function handle the value for the day-of-month component. Currently both map anything less than 1 to 1. According to ECMA-262 (3rd), section 15.9.1.12 step 8, the value should simply be added as-is.

See also bug 9523 and change 3.19 to jsdate.c

Note that bug 9523 didn't update the date_UTC(...) function, I'll file a bug on that shortly.

The Date constructor bug was found and fixed by Ilya Frank <[e-mail]>, a colleague of mine at Danger Inc. Based on that I discovered and fixed the UTC function version of the bug.

Comment 1

[jag (Peter Annema)]

See bug 363578 for fixing the UTC function in jsdate.c.

Comment 2

[jag (Peter Annema)]

Attachment: Same, but with most of the shared code factored out

Comment 3

[Attila Szegedi]

Comment on attachment 263106 [details] [diff] [review]
Same, but with most of the shared code factored out

Looks okay. Also a nice refactoring to eliminate some code duplication.

Comment 4

[Attila Szegedi]

Committed the patch to CVS.

Comment 5

[jag (Peter Annema)]

Cool! Thanks for checking this in. Is there a test we can/should update?

Comment 6

[Norris Boyd]

Adding target milestone of 1.6R6 based on the date this bug was resolved FIXED.