363993 - Trunk: "Click to always load..." fails for existing address card

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Mike Cowperthwaite]

TB 3a1-1206 thru 3a1-1215.

If a message contains remote content, and was sent from someone who already exists in the AB but has not been set to allow HTML, clicking the whitelisting link has no action.  (Works fine if the AB card doesn't exist; also, works fine in the 1.8.1 branch.)

Steps to reproduce:
1) Create a message with remote content that is "From" an entry in the current AB.
2) Turn off the "Allow HTML" option in that AB entry, if it's not already.
3) View the message: content should be blocked, and the Remote Content banner-alert should be displayed.
4) Click the "Click here to always load remote images from <address>" text in the banner.
5) View the AB card for the "sender."

Actual results:
4) The message appearance does not change
5) The "allow HTML" option remains unset

Expected results:
4) The remote content is handled (e.g. image shown)
5) The "allow HTML" option is set

Comment 1

[Scott MacGregor]

good catch mcow.

I get this JS error when I click on the always allow link:

JavaScript error: chrome://messenger/content/mailWindowOverlay.js, line 2309: ad
drbook.modifyCard is not a function

Comment 2

[Scott MacGregor]

Looks like this was triggered by Bug #360777

Comment 3

[Scott MacGregor]

The patch I'm about to post for this bug can be improved when Bug 359352 is fixed.

Comment 4

[Scott MacGregor]

Attachment: the fix

modifyCard is a property of nsIAbDirectory so we need to QI addrbook. 

When cardForEmailAddress becomes a property on nsIAbDirectory, we won't have to explicitly QI to nsIAbDirectory before calling modifyCard.

Comment 5

[Scott MacGregor]

fixed on the trunk.