364034 - Sunbird crashed when closing dialog after problems with date picker popup menu [@ DoDeletingFrameSubtree]

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Omar Bajraszewski]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.8.1) Gecko/20061010 Firefox/2.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.8.1) Gecko/20061010 Firefox/2.0

I think it's a regression- Cancel button didn't work in "choose date" window and I clicked "X"- it causes a crash. Talkback sent a report:TB27394256Q

Reproducible: Always

Steps to Reproduce:
1. Go > Date
2. Click drop-down button [v]
3. Click month name (month-list popup appears: do NOT click it)
4. Click year (month-list popup disappears)
5. Click drop-down menu
6. Notice cancel button doesn't work
7.Click X 
Actual Results:  
Crash

Expected Results:  
1)Date picker doesn't freeze
2)Cancel button works
3) Sunbird  doesn't crash

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061215 Calendar/0.4a1

Comment 1

[Omar Bajraszewski]

Depends on bug: 29703?

Comment 2

[Omar Bajraszewski]

(In reply to comment #1)
> Depends on bug: 29703?
> 

Sorry I was wrong- I was suggested by comment https://bugzilla.mozilla.org/show_bug.cgi?id=356505#c11

Comment 3

[Omar Bajraszewski]

Doesn't crash with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061129 Calendar/0.4a1

Crashes with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061130 Calendar/0.4a1

Comment 4

[Omar Bajraszewski]

I know it's maybe too early but I nominate it as blocker- major function is broken and I can't imagine releasing Sunbird 0.5 without fixing it

Comment 5

[Stefan Sitter [:ssitter]]

Confirmed crash with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20061215 Thunderbird/3.0a1 - Build ID: 2006121503 and Lightning/0.4a1 (2006121603).

Same as Bug 360339?

Talkback ID: TB27399722G (Thunderbird), TB27399568Y TB27399356Y (Sunbird)

DoDeletingFrameSubtree  [mozilla\layout\base\nscssframeconstructor.cpp, line 9595]
DoDeletingFrameSubtree  [mozilla\layout\base\nscssframeconstructor.cpp, line 9601]
DoDeletingFrameSubtree  [mozilla\layout\base\nscssframeconstructor.cpp, line 9601]
DoDeletingFrameSubtree  [mozilla\layout\base\nscssframeconstructor.cpp, line 9601]
DoDeletingFrameSubtree  [mozilla\layout\base\nscssframeconstructor.cpp, line 9601]
DeletingFrameSubtree  [mozilla\layout\base\nscssframeconstructor.cpp, line 9655]
nsCSSFrameConstructor::RemoveMappingsForFrameSubtree  [mozilla\layout\base\nscssframeconstructor.cpp, line 9679]
nsFrameList::DestroyFrames  [mozilla\layout\generic\nsframelist.cpp, line 60]
nsFrameList::DestroyFrames  [mozilla\layout\generic\nsframelist.cpp, line 60]
nsFrameList::DestroyFrames  [mozilla\layout\generic\nsframelist.cpp, line 60]
nsFrameList::DestroyFrames  [mozilla\layout\generic\nsframelist.cpp, line 60]
nsFrameList::DestroyFrames  [mozilla\layout\generic\nsframelist.cpp, line 60]
nsFrameList::DestroyFrames  [mozilla\layout\generic\nsframelist.cpp, line 60]
nsFrameList::DestroyFrames  [mozilla\layout\generic\nsframelist.cpp, line 60]
nsFrameList::DestroyFrames  [mozilla\layout\generic\nsframelist.cpp, line 60]
nsFrameList::DestroyFrames  [mozilla\layout\generic\nsframelist.cpp, line 60]
nsFrameList::DestroyFrames  [mozilla\layout\generic\nsframelist.cpp, line 60]
nsFrameManager::Destroy  [mozilla\layout\base\nsframemanager.cpp, line 303]
DocumentViewerImpl::Destroy  [mozilla\layout\base\nsdocumentviewer.cpp, line 1610]
nsDocShell::Destroy  [mozilla\docshell\base\nsdocshell.cpp, line 3472]
nsXULWindow::Destroy  [mozilla\xpfe\appshell\src\nsxulwindow.cpp, line 507]
nsWebShellWindow::Destroy  [mozilla\xpfe\appshell\src\nswebshellwindow.cpp, line 828]
nsWebShellWindow::HandleEvent  [mozilla\xpfe\appshell\src\nswebshellwindow.cpp, line 387]
nsWindow::DispatchEvent  [mozilla\widget\src\windows\nswindow.cpp, line 1115]
nsWindow::DispatchStandardEvent  [mozilla\widget\src\windows\nswindow.cpp, line 1155]
nsWindow::ProcessMessage  [mozilla\widget\src\windows\nswindow.cpp, line 4360]
0x0012f7d8

Comment 6

[Joey Minta]

Probably a dupe of bug 360339.  If you have a debug build and can confirm a similar assertion pattern, that'd be helpful.

Comment 7

[Stefan Sitter [:ssitter]]

(In reply to comment #6)

The only assertion I see before the crash is 

###!!! ASSERTION: Null out-of-flow for placeholder?: 'outOfFlow', file y:\dev\sb-trunk\mozilla\layout\generic\nsPlaceholderFrame.h, line 172

Comment 8

[Martijn Wargers (dead)]

This could very well be the same issue as bug 360339, a minimal testcase that reproduces the crash would make it clear.
I guess Sunbird has to work around this issue.

Comment 9

[Omar Bajraszewski]

I can't reproduce it using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.2pre) Gecko/20070216 Calendar/0.4a1
Shall I mark it as worksforme?

Comment 10

[Stefan Sitter [:ssitter]]

(In reply to comment #9)
This seems to be a Trunk only issue, therefore only Sunbird 0.6a1 would be affected. 

Comment 11

[Stefan Sitter [:ssitter]]

Works in Sunbird/0.4a1 (2007-02-25-05, win32, mozilla1.8)
Crash in Sunbird/0.6a1 (2007-02-25-05, win32, trunk) (no talkback reaction)
 -> Issue is trunk only, doesn't need to block 0.5 release

Comment 12

[Mats Palmgren (inactive)]

Does the "wallpaper" patch in bug 372576 fix this crash?

Comment 13

[Mats Palmgren (inactive)]

Is Sunbird win32 only?
(otherwise I don't understand the conclusion in comment 11)

Anyway, please test in a trunk build with the fix for bug 372576.

Comment 14

[Omar Bajraszewski]

(In reply to comment #13)
> Is Sunbird win32 only?
> (otherwise I don't understand the conclusion in comment 11)
> 
> Anyway, please test in a trunk build with the fix for bug 372576.
> 

Is the patch checked in? I tried to reproduce with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a3pre) Gecko/20070304 Calendar/0.6a1
and it crashed: TB29940068Z

Comment 15

[Martijn Wargers (dead)]

Omar, you need the 2007-03-05 trunk build, thanks.

Comment 16

[Omar Bajraszewski]

Attachment: Cancel button works as year dropdown menu

(In reply to comment #15)
> Omar, you need the 2007-03-05 trunk build, thanks.
> 
Yes- it fixes the problem. Sunbird doesn't crash. But:
1)Cancel button still doesn't work
2)It works as dropdown menu (look at screenshot)-if not try to repeat the steps 1-6 again

Shall I create a new bug for the described problems and mark this bug 364034 as WFM?

Comment 17

[Martijn Wargers (dead)]

Yes, please, mark this bug fixed (by bug 372576).

Comment 18

[Stefan Sitter [:ssitter]]

(In reply to comment #16)
> Shall I create a new bug for the described problems

This is already filed as Bug 362498.

Doesn't crash for me using Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a3pre) Gecko/20070305 Calendar/0.6a1 -> Fixed by Bug 372576.