364195 - No way to search for private comments

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Reed Loden [:reed]]

There's an "Attachment is private" option, but there's no "Comment is private" option, meaning there's no way to search for private comments. :(

Comment 1

[Reed Loden [:reed]]

Attachment: patch - v1

This works for me on prodpatches, but I'm not sure if I added it to everything I was supposed to.

Comment 2

[Reed Loden [:reed]]

Attachment: patch - v2

This one actually has checks to make sure only the people that can see the comments can search for them. :P

I don't like this logic, but I don't know of any other way to do it.

Comment 3

[Dave Miller [:justdave]]

Comment on attachment 249009 [details] [diff] [review]
patch - v2

Logic looks sound, but I don't like using "isprivate" as the field name, as from the context it's being used it, that makes it look like we're searching for whether the bug is private or not.

longdesc and commenter are the only other things in that table we can search right now, but those are obvious from the context.  I believe we have comment types now (to distinguish duplicate and attachment added and so forth) and that might be worth searching on eventually, so doing a group with longdescs.foo might not be so bad.

So let's make this one longdescs.isprivate

Comment 4

[Reed Loden [:reed]]

Attachment: patch - v3

s/isprivate/longdescs.isprivate/... is that all I needed to do?

Comment 5

[Reed Loden [:reed]]

Checking in Bugzilla/Field.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Field.pm,v  <--  Field.pm
new revision: 1.24; previous revision: 1.23
done
Checking in Bugzilla/Search.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search.pm,v  <--  Search.pm
new revision: 1.143; previous revision: 1.142
done

Comment 6

[Max Kanat-Alexander]

Added to the release notes on bug 255155.

Comment 7

[Max Kanat-Alexander]

The correct bug number for those release notes is actually bug 349423.