364644 - Re-enable livemark-reload functionality

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Asaf Romano (gone)]

Livemark-reloading and bookmarks-sorting commands were not fixed to work with the new per-view PlacesController (see bug 359462).

Comment 1

[Asaf Romano (gone)]

I will file a separate bug for the sort commands.

Comment 2

[Asaf Romano (gone)]

Attachment: patch

* Bring back reload functionality
* Don't enable the command for live-bookmark children for now
* Use the static 2.0-like "Reload Live Bookmark"
* Remove the organizer keyboard shortcut for this command
* Move the menu-item back to the edit menu
* Remove "sort by name" menu-item from the edit menu

Comment 3

[(not reading, please use [e-mail] instead)]

Comment on attachment 254869 [details] [diff] [review]
patch

r=sspitzer, sorry for the delay.

one nit:

"childs of a live bookmark"

shouldn't it be:

"children of a live bookmark"

Comment 4

[Asaf Romano (gone)]

*ugh*, sure thing!

Comment 5

[Asaf Romano (gone)]

Attachment: as checked in

mozilla/browser/components/places/content/controller.js 1.125
mozilla/browser/components/places/content/places.xul 1.61
mozilla/browser/components/places/content/placesOverlay.xul 1.6
mozilla/browser/locales/en-US/chrome/browser/places/places.dtd 1.17

Comment 6

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv