370099 - places-based bookmarks blockers

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Asaf Romano (gone)]

tracker for bugs which block turning on places-based bookmarks on trunk.

Comment 1

[Wayne Woods]

It looks to me like bug 374528 is a dupe of this meta. This one is the only one with all the important dependencies set, but that one is set to block bug 374945 (Fx 3 Places meta).

Comment 2

[Dietrich Ayala (:dietrich)]

(In reply to comment #1)
> It looks to me like bug 374528 is a dupe of this meta. This one is the only one
> with all the important dependencies set, but that one is set to block bug
> 374945 (Fx 3 Places meta).
> 

This bug is for tracking bugs that must be fixed before Places bookmarks are turned on by default. Bug 374528 is about backup/restore. How is it a dupe?

Comment 3

[Wayne Woods]

Sorry, I misinterpreted what that bug was about.

Comment 4

[Asaf Romano (gone)]

Attachment: turn it on

Comment 5

[Dietrich Ayala (:dietrich)]

nsNavBookmarks::InitDefaults is behind the MOZ_PLACES_BOOKMARKS define, so doesn't get called when sidegrading from non-bookmarks to bookmarks.

when turning on bookmarks, we need to bump the schema version, in order to trigger a full re-initialization of the bookmarks tables.

Comment 6

[(not reading, please use [e-mail] instead)]

we realized that we don't need to bump the schema (even though I did for bug #371827)

in nsBrowserGlue.js, we have code that checks the browser.places.importBookmarksHTML pref.  if true, we'll force a migration.

that pref defaults to true, and is only set to false after the import succeeds (in nsBrowserGlue.js)

note, that code in nsBrowserGlue.js is behind #ifdef MOZ_PLACES_BOOKMARKS, running the trunk the first time will migrate you, even if the schema version matched.

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 264940 [details] [diff] [review]
turn it on

let's do it

Comment 8

[Al Billings [:abillings - ex-MoCo]]

Marking it as verified to get off QA resolved plate and because we're using Places bookmarks now.

Comment 9

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv