365005 - Infamous red XUL error for menu_HelpPopup_reportertoolmenu when using differently localized builds

Status: RESOLVED FIXED

(Other Applications Graveyard :: Reporter, defect)

Description

[Karsten Düsterloh]

Steps to reproduce, eg. for SeaMonkey:
- create new profile with an eg. en-US build
- start differently localized build, eg. de-AT
==> Red XUL error, but only for reporter, not for other extensions like Venkman or DOMI. Checking the chrome.rdf in the profile shows that all other extensions' selectedLocale attributes have been converted from en-US to de-AT except that for reporter...

Comment 1

[Karsten Düsterloh]

Attachment: add localeVersion to package description

The core problem is a missing localeVersion in the package description. When starting up and setting selectedLocale to the current locale, reporter's (non-existent) version does not match the current one...

Comment 2

[Karsten Düsterloh]

Attachment: let the build system set the correct version number

Let the build system do the versioning, like we do for Venkman etc.

Comment 3

[Robert Accettura [:raccettura]]

The Christmas gift of code... priceless.

;-)

Comment 4

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Comment on attachment 249662 [details] [diff] [review]
let the build system set the correct version number

The flag I am setting is not a mistake.

Comment 5

[[e-mail]]

Comment on attachment 249662 [details] [diff] [review]
let the build system set the correct version number

>         chrome:description="Broken Web Site Reporting Tool"
The web site reporting tool is now fixed, right ;-)

nth-a=me for wherever...

Note that we can always rerelease reporter.xpi separately.

Comment 6

[Karsten Düsterloh]

Landed on trunk and MOZILLA_1_8_BRANCH.

Comment 7

[Robert Kaiser]

We should probably think about landing this on 1.8.0 as well...

Comment 8

[Robert Kaiser]

Comment on attachment 249662 [details] [diff] [review]
let the build system set the correct version number

first-a=me for 1.0.8, one still needed to go

Comment 10

[Karsten Düsterloh]

Landed on MOZILLA_1_8_0_BRANCH.