365171 - context menu delete of personal toolbar bookmark can delete history item if focused

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[(not reading, please use [e-mail] instead)]

1) have history sidebar open to view by last visited
2) click on the top item to the left of the favicon (so that it focuses, but does not load)
3) then, right click on a bookmark on your personal toolbarfolder
4) and attempt to context menu delete it
5) the history item is deleted not the bookmark

mano thinks:  "two places controllers (may be) enabled on the same time"

Comment 1

[Asaf Romano (gone)]

I wish we didn't have the views-concept already in-place.

Comment 2

[Asaf Romano (gone)]

Attachment: one approach

Comment 3

[(not reading, please use [e-mail] instead)]

Comment on attachment 249808 [details] [diff] [review]
one approach

r=sspitzer, thanks asaf.

Comment 4

[Asaf Romano (gone)]

mozilla/browser/components/places/content/commands.inc 1.23
mozilla/browser/components/places/content/context.inc 1.13
mozilla/browser/components/places/content/controller.js 1.109
mozilla/browser/components/places/content/menu.xml 1.62
mozilla/browser/components/places/content/toolbar.xml 1.68
mozilla/browser/components/places/content/tree.xml 1.47
mozilla/browser/components/places/content/utils.js 1.3

Comment 5

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv