The default bug view has changed. See this FAQ.

Don't focus the content area when closing a places context menu

RESOLVED FIXED in Firefox 17

Status

()

Firefox
Bookmarks & History
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
Firefox 17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 644667 [details] [diff] [review]
patch

This was added in bug 365171. Whereas this.focus() in buildContextMenu is gone by now, this seems to be a leftover. As far as I can tell, no special treatment is needed. Focus should just go back to where it was.
Attachment #644667 - Flags: review?(mak77)
(Assignee)

Updated

5 years ago
Blocks: 365171
Comment on attachment 644667 [details] [diff] [review]
patch

Review of attachment 644667 [details] [diff] [review]:
-----------------------------------------------------------------

I think this was here to update places commands on focus, though looks like it's no more needed and I think it's fine to remove it.
But since Mano originally added it, he may have some insight on the reasons.
Attachment #644667 - Flags: review?(mano)
Attachment #644667 - Flags: review?(mak77)
Attachment #644667 - Flags: feedback+
Comment on attachment 644667 [details] [diff] [review]
patch

Indeed.
Attachment #644667 - Flags: review?(mano) → review+
(Assignee)

Comment 3

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/fadf5073473d
https://hg.mozilla.org/mozilla-central/rev/fadf5073473d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
You need to log in before you can comment on or make changes to this bug.