Closed Bug 365342 Opened 18 years ago Closed 18 years ago

Sunbird branch vs. trunk require version number changes

Categories

(Calendar :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Sunbird 0.5

People

(Reporter: mattwillis, Assigned: mattwillis)

References

Details

Attachments

(1 file, 1 obsolete file)

Now that we are building Sunbird on branch as well as trunk, for user clarity (as well as AUS sanity) we should increment trunk's version number forward.

In the discussions for bug 364589, both mvl and I thought 0.6a1 sounds good for trunk, and leave 0.4a1 for branch.
Flags: blocking-calendar0.5+
Reversing dependencies
Blocks: 364589
No longer depends on: 364589
Attached patch TRUNK ONLY - Bumps version to 0.6a1 (obsolete) — — Splinter Review
mvl for the calendar bits, morgamic for the aus piece
Attachment #251399 - Flags: second-review?(morgamic)
Attachment #251399 - Flags: first-review?(mvl)
Comment on attachment 251399 [details] [diff] [review]
TRUNK ONLY - Bumps version to 0.6a1

r=mvl
Attachment #251399 - Flags: first-review?(mvl) → first-review+
For this change in mozilla/webtools/aus/xml/inc/config-dist.php

     'Sunbird'     =>  array(
-        '0.4a1'   =>  'trunk',
-        '0.5'     =>  'trunk'
+        '0.4a1'   =>  '0.5',
+        '0.5'     =>  '0.5',
+        '0.6a1'   =>  'trunk'

you'll need to change the tinder-config.pl's on the branch so that the variable $update_version is also '0.5'. Or you could change the above to 'branch', since that's already in use in the tinderbox config. (This is to make sure that update requests are mapped to the right directory in the AUS data store.)

Since this parameter is really about the branch the build is from, rather than the app version, I would suggest the second option is less likely to be superseded, and therefore better.
I actually had that in there first but changed it.

Ok. I'll make a new patch for the AUS bit.


The trunk version # stuff is checked in.
Attachment #251399 - Attachment is obsolete: true
Attachment #251418 - Flags: first-review?(morgamic)
Attachment #251399 - Flags: second-review?(morgamic)
Comment on attachment 251418 [details] [diff] [review]
AUS bit updated per cf's comments

Looks good -- I can commit the change on trunk.
Attachment #251418 - Flags: first-review?(morgamic) → first-review+
Blocks: 367380
(In reply to comment #7)
morgamic:
Is the /m/webtools piece committed (and pushed to production)?
Yes, bug 367804 (which is getting bug 367804 into production) was FIXED today.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
No longer blocks: 367380
Status: RESOLVED → VERIFIED
Flags: blocking-calendar0.5+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: