367804 - AUS2 configuration update for sunbird nightlies

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: WebOps: Other, task)

Description

[Michael Morgan [:morgamic]]

Need to update AUS2 to deploy patch from bug 364628.  The changes cover some config changes the affect the mapping of incoming client versions to their directory on disk.  It only affects nightlies.

I ran this through the acceptance tests and did spot checking for 1.5.* and 2.0.* Firefox updates.  All looked good.

Preed, can I get a what-what or a woot-woot? (+r/-r)?

Comment 1

[Michael Morgan [:morgamic]]

Sorry, wrong component.  Also, update tag is "AUS2_PRODUCTION" and the affected files are:
./index.php
./inc/config-dist.php
./inc/patch.class.php

Comment 2

[J. Paul Reed [:preed]]

Yeah, sorry for the delay; looks good.

One quick question on the patch:

in getBranch, since you're using regexes, does it make sense to escape the ., too? I see you already escape the * (to turn it into a .*). Or is that happening somewhere else and I'm missing it?

Comment 3

[Michael Morgan [:morgamic]]

(In reply to comment #2)
> Yeah, sorry for the delay; looks good.
Thanks for taking a look. :)

> One quick question on the patch:
> 
> in getBranch, since you're using regexes, does it make sense to escape the .,
> too? I see you already escape the * (to turn it into a .*). Or is that
> happening somewhere else and I'm missing it?
When it's doing the pattern match it calls preg_quote() on the pattern before using it:
http://php.osuosl.org/preg_quote

That escapes the pattern properly so it's not too greedy / unpredictable.

Comment 4

[Jeremy Orem [:oremj]]

[root@do-stage01 app]# cvs -q up
P index.php
P inc/config-dist.php
P inc/patch.class.php