365521 - bug/create/create-guided has unescaped &

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[victory <[e-mail]>]

<a href="duplicates.cgi?[% productstring %]&format=simple" target="somebugs">All-time Top 100</a> (loaded initially) |
    <a href="duplicates.cgi?[% productstring %]&format=simple&sortby=delta&reverse=1&maxrows=100&changedsince=14" target="somebugs">Hot in the last two weeks</a>  

  src="duplicates.cgi?[% productstring %]&format=simple">

Comment 1

[Max Kanat-Alexander]

The guided bug entry form is going to be removed from the core Bugzilla code (see bug 474086), so we won't be fixing these bugs in upstream Bugzilla. It was always just an example page, to begin with. I'm moving the bugs to the bmo component, to at least preserve a record of the fact that these things may need to be fixed for bmo.

Comment 2

[Gervase Markham [:gerv]]

Problem confirmed as still present.

Gerv

Comment 3

[Gervase Markham [:gerv]]

Attachment: Patch v.1

This is a roll-up patch which fixes this bug, plus bug 365056, and
there's an update to the default OS list to include Windows 7.

Gerv

Comment 4

[Reed Loden [:reed]]

We still support Windows 2000 in Firefox, so I'd keep it.

Comment 5

[Dave Miller [:justdave]]

Comment on attachment 359475 [details] [diff] [review]
Patch v.1

Looks good to me, unless you need to take Reed's comment 4 into account.

+1 for getting rid of the anti-Netscape stuff, we're long past having to worry about that anymore :)

Comment 6

[Gervase Markham [:gerv]]

justdave: is it OK to check this in on the trunk and 3.2 branch?

Gerv

Comment 7

[Frédéric Buclin]

OK, to take it (especially because it fixes bug 365056), but please leave Windows 2000 in the list.

Comment 8

[Frédéric Buclin]

gerv, please remove matches.0 from filterexceptions.pl. The tree is now orange:

not ok 27 - (en/default) template/en/default/bug/create/create-guided.html.tmpl - filterexceptions.pl has extra members:
#   matches.0
# --WARNING

Comment 9

[Gervase Markham [:gerv]]

Fixed. Sorry :-|

Gerv

Comment 10

[Gervase Markham [:gerv]]

Checked in on trunk. Getting a 3.2 tree is proving difficult over the FOSDEM network. I may have to check it in on the branch once I get home.

Gerv

Comment 11

[Frédéric Buclin]

Don't forget to paste the new rev numbers. ;)

Comment 12

[Gervase Markham [:gerv]]

Trunk:

Checking in template/en/default/bug/create/create-guided.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create-guided.html.tmpl,v  <--  create-guided.html.tmpl
new revision: 1.45; previous revision: 1.44

Checking in template/en/default/filterexceptions.pl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/filterexceptions.pl,v  <--  filterexceptions.pl
new revision: 1.125; previous revision: 1.124

Gerv

Comment 13

[Gervase Markham [:gerv]]

Checking in template/en/default/bug/create/create-guided.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create-guided.html.tmpl,v  <--  create-guided.html.tmpl
new revision: 1.42.2.2; previous revision: 1.42.2.1
done

Checking in template/en/default/filterexceptions.pl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/filterexceptions.pl,v  <--  filterexceptions.pl
new revision: 1.111.2.4; previous revision: 1.111.2.3
done

Gerv