Closed
Bug 365576
Opened 19 years ago
Closed 19 years ago
Update SeaMonkey's copyright strings to 2007
Categories
(SeaMonkey :: General, defect)
SeaMonkey
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: standard8, Assigned: standard8)
Details
(Keywords: fixed-seamonkey1.1, late-l10n)
Attachments
(3 files, 1 obsolete file)
5.66 KB,
patch
|
kairo
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
21.09 KB,
patch
|
Details | Diff | Splinter Review | |
23.52 KB,
patch
|
kairo
:
review+
neil
:
superreview+
kairo
:
approval-seamonkey1.1+
|
Details | Diff | Splinter Review |
We obviously need to do this - we've got xpfe and suiterunner to check on this year :-(
I'd like to follow Firefox's lead with the help files - they have put a copyright.years string into platformString.dtd and all the help files reference that (see bug 365553). I'd like to do the same, but I think brand.dtd would be the better location in our case (we don't have platformString.dtd). Any comments?
Assignee | ||
Comment 1•19 years ago
|
||
We should probably block the 1.1 release with this as well... ;-)
Flags: blocking-seamonkey1.1?
Assignee | ||
Comment 2•19 years ago
|
||
This updates just the main version strings for xpfe and toolkit builds of SeaMonkey (I've not done help yet). This will fix --version, about & license (note that suiterunner about & license were done in bug 365553).
Will we want to update about.xhtml & license.xhtml on the branch for 1.1 considering that the changes affect l10n? Bug 322172 has some comments on this.
Attachment #250091 -
Flags: superreview?(neil)
Attachment #250091 -
Flags: review?(kairo)
Assignee | ||
Comment 3•19 years ago
|
||
This follows what FF did in bug 365553 and should make it easier next year to bump the copyright strings in help (also hopefully reduces l10n effort).
Attachment #250093 -
Flags: superreview?(neil)
Attachment #250093 -
Flags: review?(kairo)
Updated•19 years ago
|
Attachment #250091 -
Flags: superreview?(neil) → superreview+
![]() |
||
Comment 4•19 years ago
|
||
Comment on attachment 250091 [details] [diff] [review]
Bump main copyright strings (checked in to trunk)
Looks good to me.
And yes, please also do that for branch, though please don't use the "new entity approach" there for help files etc. Just change existing strings and write a note to m.d.l10n when checking in.
Attachment #250091 -
Flags: review?(kairo) → review+
![]() |
||
Comment 5•19 years ago
|
||
Comment on attachment 250093 [details] [diff] [review]
Bump help strings and make it easier for next time
looks good to me for trunk (see my last comment for branch). a=me
Attachment #250093 -
Flags: review?(kairo) → review+
![]() |
||
Comment 6•19 years ago
|
||
(doing too much approvals, I guess. this was r=me, not a=me, as I flagged correctly)
Assignee | ||
Updated•19 years ago
|
Attachment #250091 -
Attachment description: Bump main version strings → Bump main copyright strings (checked in to trunk)
Comment 7•19 years ago
|
||
Comment on attachment 250093 [details] [diff] [review]
Bump help strings and make it easier for next time
As it's the same string each time, is it worth putting the whole copyright statement in the dtd, or are we planning on reusing the years elsewhere?
Attachment #250093 -
Flags: superreview?(neil) → superreview+
Assignee | ||
Comment 8•19 years ago
|
||
Revised help patch with the full copyright string in brand.dtd as per Neil's suggestion. I'll check this in tomorrow morning.
Assignee | ||
Comment 9•19 years ago
|
||
Reduced patch for 1.1 branch - strings in help just replace the numbers. When this is checked in, I'll put a note on m.d.l10n saying that they've been updated, although it not necessary for all locales to be updated.
Attachment #250632 -
Flags: superreview?(neil)
Attachment #250632 -
Flags: review?(kairo)
Attachment #250632 -
Flags: approval-seamonkey1.1?
Updated•19 years ago
|
Attachment #250632 -
Flags: superreview?(neil) → superreview+
Assignee | ||
Updated•19 years ago
|
Attachment #250093 -
Attachment is obsolete: true
![]() |
||
Comment 10•19 years ago
|
||
Comment on attachment 250632 [details] [diff] [review]
Branch version
r+a=me (I'm countung Neil's sr for a branch-only patch as implicit first approval here)
Attachment #250632 -
Flags: review?(kairo)
Attachment #250632 -
Flags: review+
Attachment #250632 -
Flags: approval-seamonkey1.1?
Attachment #250632 -
Flags: approval-seamonkey1.1+
Assignee | ||
Updated•19 years ago
|
Attachment #250631 -
Attachment description: Bump help strings and make it easier for next time v2 → Bump help strings and make it easier for next time v2 (checked into trunk)
Assignee | ||
Comment 11•19 years ago
|
||
I've just checked the branch patch in -> all fixed.
Status: NEW → RESOLVED
Closed: 19 years ago
Flags: blocking-seamonkey1.1?
Keywords: fixed-seamonkey1.1,
late-l10n
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•