365592 - The tab bar is overflowing briefly when opening a second tab

Status: RESOLVED WORKSFORME

(Firefox :: Tabbed Browser, defect, P5)

Description

[Martijn Wargers (dead)]

To reproduce this, you need to have the option 'Always show the tab bar' unchecked.
Just open a new tab or open a new link in a tab, when you don't have any tabs opened yet. In that case, you briefly see the horizontal arrowscrollbars, which you get when the tabs are overflowing the tab bar.

This regressed between 2006-12-19 and 2006-12-20, I suspect a regression from bug 363933 somehow.

Comment 1

[Mats Palmgren (inactive)]

I'm pretty sure this is the same underlying problem as in bug 365477.
I would appreciate if you could test that the patch fixes it.

Comment 2

[Martijn Wargers (dead)]

Yeah, I would have thought too that this was basically the same as  bug 365477, but I couldn't reproduce that one, so that's why I filed this bug.
I tried your patch (I rebuilt layout/ and toolkit/), but unfortunately, it seems I can still reproduce the issue with your patch.

Comment 3

[Mike Connor [:mconnor]]

I'm not seeing this, can it still be reproduced?

Comment 4

[Martijn Wargers (dead)]

Yes, I'm still seeing this, using:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007081105 Minefield/3.0a8pre

Comment 5

[hhh]

Seeing this also using Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a8pre) Gecko/2007081807 Minefield/3.0a8pre ID:2007081807. I tried to get a screenshot but it flashes too briefly.

http://forums.mozillazine.org/viewtopic.php?p=3017345#3017345

Comment 6

[Mike Connor [:mconnor]]

ryan mentioned something about fixing this, not sure if that's correct.

Not a blocker, wanted polish though.

Comment 7

[Ryan Flint [:rflint] (ping via IRC for reviews)]

This was 'fixed' by bug 387345 in the sense that it no longer occurs, but whatever the underlying issue was certainly hasn't been. When I noticed it going away in the process of writing that patch, I reverted it bit by bit and found that simply changing the tab structure took care of it: http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/base/content/tabbrowser.xml&rev=1.251&mark=3103-3105#3087

Comment 8

[Martijn Wargers (dead)]

Well, in that case this bug can be closed, no?

Comment 9

[Dão Gottwald [:dao]]

It should be morphed to a core bug or resolved as WORKSFORME.