365981 - Places XUL cleanup

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Asaf Romano (gone)]

To keep the places UI bits and myself sane I would like to make the following changes to the places XUL files:

1. Just say no to .inc files: We should use an overlay instead which would also load its dnd and script dependencies.
2. Don't set label and accesskey attributes on command elements directly. It's no t easy to override those (the command element attributes have higher priority).

Comment 1

[Asaf Romano (gone)]

3. Don't use placesCmd_ prefix for commands which are not supported by the places controller.

Comment 2

[Asaf Romano (gone)]

4. Use the PlacesUtils object to cache places.properties.

I also had to change sb-loader.js not to rely on the loading-order of scripts.

Comment 3

[Asaf Romano (gone)]

Attachment: patch

Comment 4

[(not reading, please use [e-mail] instead)]

Comment on attachment 250534 [details] [diff] [review]
patch

r=sspitzer, thanks for all this cleanup.

Comment 5

[Asaf Romano (gone)]

mozilla/browser/base/content/browser-places.js  1.17
mozilla/browser/base/content/browser-sets.inc 1.87
mozilla/browser/base/content/browser.xul 1.332
mozilla/browser/base/content/global-scripts.inc 1.13
mozilla/browser/base/content/macBrowserOverlay.xul 1.12
mozilla/browser/components/places/jar.mn 1.30
mozilla/browser/components/places/content/commands.inc delete
mozilla/browser/components/places/content/context.inc delete
mozilla/browser/components/places/content/controller.js 1.110
mozilla/browser/components/places/content/history-panel.xul 1.4
mozilla/browser/components/places/content/menu.xml 1.63
mozilla/browser/components/places/content/places.js 1.72
mozilla/browser/components/places/content/places.xul 1.56
mozilla/browser/components/places/content/placesOverlay.xul initial revision: 1.1
mozilla/browser/components/places/content/placesPopup.xul 1.5
mozilla/browser/components/places/content/utils.js 1.4
mozilla/browser/components/safebrowsing/content/sb-loader.js 1.11

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

I'm seeing bustage in the linux nightly just after this patch landed. On launch:

XML Parsing Error: mismatched tab. Expected: </commandset>.
Location: chrome://browser/content/browser.xul
Line Number: 1380, Column 3:

</window>
--^

Comment 7

[Asaf Romano (gone)]

Thanks Nick. fixed:
mozilla/browser/base/content/browser-sets.inc 1.88

Comment 9

[Bill Gianopoulos [:WG9s]]

This patch appears to have completely broken the history sidebar.

Comment 10

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv