--disable-places broken due to missing overlay

RESOLVED FIXED

Status

()

Firefox
Bookmarks & History
RESOLVED FIXED
11 years ago
8 years ago

People

(Reporter: Mook, Assigned: Mook)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
(See URL)

When building with --disable-places, chrome://browser/content/places/placesOverlay.xul doesn't exist, so the overlay fails.

(Building with that fixed to see if it does anything else to my build... :/ )

Oh, if --disable-places isn't going to be supported, might want to consider telling me in configure ;)
(Assignee)

Comment 1

11 years ago
Created attachment 250803 [details] [diff] [review]
add ifdef MOZ_PLACES

Manually editing browser.jar got everything to work again, still building in case I screwed up.
Assignee: nobody → mook.moz+sites.org.mozilla.bugzilla
Status: NEW → ASSIGNED
Attachment #250803 - Flags: review?(mano)
Comment on attachment 250803 [details] [diff] [review]
add ifdef MOZ_PLACES

r=mano
Attachment #250803 - Flags: review?(mano) → review+
mozilla/browser/base/content/browser.xul 1.333
mozilla/browser/base/content/macBrowserOverlay.xul 1.13
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.