366120 - QuickSearch gets confused by colons in quotes

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Jesse Ruderman]

1. Search BMO for:
  float "sg:cri"

Result: all float bugs are returned.

Expected: only sg:critical float bugs should be returned.

I put the quotes around "sg:cri" because I didn't want the colon to confuse Bugzilla, but I guess it got confused anyway.

Comment 1

[Teemu Mannermaa (:wicked)]

Quoting only preserves whitespace and so doesn't protect any colons. That word becomes |sg:cri| but as sg is not a known field it will just be ignored. Previously this would have resulted in an "unknown field" error (see bug 365082).

Comment 2

[Jesse Ruderman]

Yes, it does seem that way.  Commas break it too: https://bugzilla.mozilla.org/buglist.cgi?quicksearch=ALL+%22no+frame,+see+bug%22

Comment 4

[Teemu Mannermaa (:wicked)]

Attachment: Fix quoting, V1

Looks like JS version actually used escape/unescape to quote things between quotes. That way it preserved special characters like colon and comma in addition to whitespace. This patch brings back this support by using url_quote/url_decode functions from Util.pm instead own code to preserver whitespace only.

Comment 5

[Frédéric Buclin]

Comment on attachment 258684 [details] [diff] [review]
Fix quoting, V1

Works fine. r=LpSolit for 3.0 and tip. Maybe should we allow to protect quotes using \" so that you could correctly find fields having quotes in them. This can be done later.

Comment 6

[Frédéric Buclin]

tip:

Checking in Bugzilla/Util.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Util.pm,v  <--  Util.pm
new revision: 1.57; previous revision: 1.56
done
Checking in Bugzilla/Search/Quicksearch.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search/Quicksearch.pm,v  <--  Quicksearch.pm
new revision: 1.14; previous revision: 1.13
done


3.0 RC1:

Checking in Bugzilla/Util.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Util.pm,v  <--  Util.pm
new revision: 1.56.2.1; previous revision: 1.56
done
Checking in Bugzilla/Search/Quicksearch.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search/Quicksearch.pm,v  <--  Quicksearch.pm
new revision: 1.12.2.1; previous revision: 1.12
done