366374 - [Mac] if you open a link from outside of the app (e.g. in thunderbird) while the profile manager dialog is up, an "empty" browser window appears

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[(not reading, please use [e-mail] instead)]

if you click on a link (from tbird) while the profile manager dialog is up, an "empty" browser window appears.

seeing this on mac os x 10.4.8 trunk.  my own build from Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a2pre) Gecko/20070104 Minefield/3.0a2pre

I'll attach as screen shot.

note, if I then select a profile and start, the "empty" browser window goes away.

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: screen shot

Comment 2

[Robert Strong (they/them - no direct email)]

I did a little investigation of this while working on the DDE fiasco... I don't recall what the result is but I think I have a fix and I'll look into it.

Comment 3

[Phil Ringnalda (:philor)]

You're lucky: brade said (in bug 295248) that it was a crasher, too.

Comment 4

[Robert Strong (they/them - no direct email)]

It turns out that I don't have a fix. :(

Also, this affects opening urls in general from outside the app (e.g. using OS integration).

Comment 5

[Robert Strong (they/them - no direct email)]

For win32 we may be able to just hold off on processing dde events before the profile is loaded... not sure about other os's

Comment 6

[(not reading, please use [e-mail] instead)]

robert showed me that on his PC, he could do this:

1) start firefox with "always ask" enabled in the profile manager
2) while the profile manager was open, click on a link in tbird (he ran from the "run" menu)
3) you get the "bad browser window" with no bookmarks (and all the js errors)
4) close the bad window
5) select and start a profile
6) you'll get a new browser window loaded to the clicked link (from step 2).

he's asked me "what happens on mac in this case?"  I'll try and see when I get near my laptop.

he also figured out a way (on windows) to reproducibly crash the browser (similar to what brade saw with bug #295248)

Comment 7

[(not reading, please use [e-mail] instead)]

> he's asked me "what happens on mac in this case?"  I'll try and see when I get
> near my laptop.

robert, sorry for the delay.

for my mac, debug 10.4.8 trunk build, it does not do what windows does.  I do not get the browser window with the uri from step 2.

as for a mac opt fx 2 release build, I crash (see attached report.)  this could be the same thing that brade saw with bug #295248

Comment 8

[(not reading, please use [e-mail] instead)]

Attachment: crash report from fx2 mac release bits

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This only happens on OS X. I cannot reproduce it on Windows. 

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Empty window

This is really an empty window.

Comment 11

[Ilyse Kazar]

Posting (and voting) to keep this alive. Still happening on FF 12.0, Mac OS 10.6.8, default theme. I do not experience crashes but if FF is launched by clicking a link from any external application when Profile Manager is set to ask which profile, after choosing profile the browser goes to default load page (in my case, blank). If Profile Manger is set to not ask, when FF is launched by clicking link in another app, the page does load.

Blessings upon any dev(s) who can fix this irritating choice between not using Profile Manager, or not having pages load upon launch.

Comment 12

[Sebastian [:sebcode]]

Attachment: Bug 366374 - macos: Check for profile before opening an url. r=#mac-reviewers

There's windows-specific code which checks if a profile has been selected
before opening an url in a new window. This code is also useful for macos. It
fixes the bug that opens an empty window if you attempt to click a link before
a profile has been selected.

Comment 13

[Sebastian [:sebcode]]

Attachment: Bug 366374 - macos: Check for profile before opening an url. r=#mac-reviewers

There's windows-specific code which checks if a profile has been selected
before opening an url in a new window. This code is also useful for macos. It
fixes the bug that opens an empty window if you attempt to click a link before
a profile has been selected.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/772129350bb4
macos: Check for profile before opening an url. r=mac-reviewers,spohl

Comment 15

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/772129350bb4