366905 - Tab bar does not disappear when preference check box cleared when navigation toolbar is hidden in Mac OS X

Status: RESOLVED INCOMPLETE

(Firefox :: Shell Integration, defect)

Description

[Stephen Lark]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1

When the Fx navigation toolbar is hidden using Mac OS X's Show/Hide toolbar button, clearing the "Always show the tab bar" check box in Preferences, Tabs has no affect (i.e. clearing this check box does not hide the tab bar).

Reproducible: Always

Steps to Reproduce:
1. With only one tab open in Fx click on the Show/Hide toolbar button to hide the navigation toolbar.
2. Open tab preferences (Firefox menu, Preferences... menu item, click on Tabs)
3. Click on "Always show the tab bar" check box to clear.
Actual Results:  
Tab bar is not hidden.

Expected Results:  
Tab bar should be hidden.

I am running Mac OS X 10.4.7

Comment 1

[lowbatteries]

I can reproduce. Normally checking this box immediately toggles the tab bar if only one tab is open, but has no effect when toolbars are hidden with the toolbar button.

Comment 2

[Zack Weinberg (:zwol)]

We apologize for allowing this bug to go nearly three years without any reaction at all.

By show/hide toolbar button I assume you mean the lozenge-shaped button that is in the upper right hand corner of e.g. Finder windows.  Firefox 7.0beta (on OSX 10.6) does not put this button on its windows; I don't know if this is intentional.

If I have only one tab open and hide the navigation bar using the menu (View » Toolbars » Navigation Toolbar), unchecking the "Always show the tab bar" checkbox in Preferences causes the tab bar to vanish immediately, but that may not be the same code path at all.

I'm going to leave this open and UNCONFIRMED at least till I can find out whether the removal of the button was intentional.

Comment 3

[Zack Weinberg (:zwol)]

Okay, with a little digging I found that the button was intentionally removed (bug 573412), but might be put back in the future (bug 582957).  There is an extension that puts it back (https://addons.mozilla.org/en-US/firefox/addon/215978/).  If I use that extension to put it back, clicking the button hides all visible toolbars *including* the tab strip, and no other UI action will bring the tab strip back till I click the button again.

All of this is arguably the Wrong Thing (see discussion in the aforementioned bugs) but, in any case, it renders this bug moot.  I will make a note of it in bug 582957 so we are more likely to remember to get this right if we do bring the button back.

Comment 4

[lowbatteries]

The lozenge button has been completely removed from the operating system in 10.7 Lion, so I don't think there's any point in Firefox bringing it back.

Comment 5

[Zack Weinberg (:zwol)]

(In reply to lowbatteries from comment #4)
> The lozenge button has been completely removed from the operating system in
> 10.7 Lion, so I don't think there's any point in Firefox bringing it back.

Might be worth saying so in bug 582957, then.