367035 - No "Bookmark This Tab" and "Bookmark All Tabs" menuitms in the tabbar context menu

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Asaf Romano (gone)]

The "Bookmak This Tab" and "Bookmark All Tabs" menuitems of the context menu for the tabbar are not available in places-bookmarks builds.

Comment 1

[Asaf Romano (gone)]

Attachment: patch

Comment 2

[(not reading, please use [e-mail] instead)]

Comment on attachment 252266 [details] [diff] [review]
patch

r=sspitzer

sorry for the delay, asaf.  thanks for your patience.

Comment 3

[Asaf Romano (gone)]

mozilla/browser/base/content/browser.js 1.756
mozilla/browser/base/content/browser-places.js 1.22

Comment 4

[Dietrich Ayala (:dietrich)]

Attachment: fix regression

This fix broke adding bookmarks:

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/browser/base/content&command=DIFF_FRAMESET&file=browser-places.js&rev2=1.22&rev1=1.21

fix attached.

Comment 5

[Asaf Romano (gone)]

Comment on attachment 254317 [details] [diff] [review]
fix regression

>Index: browser/base/content/browser-places.js
>===================================================================
>RCS file: /cvsroot/mozilla/browser/base/content/browser-places.js,v
>retrieving revision 1.25
>diff -u -8 -p -r1.25 browser-places.js
>--- browser/base/content/browser-places.js	5 Feb 2007 17:46:50 -0000	1.25
>+++ browser/base/content/browser-places.js	7 Feb 2007 18:53:12 -0000
>@@ -62,17 +62,17 @@ var PlacesCommandHook = {
>   bookmarkPage: function PCH_bookmarkCurrentPage(aBrowser) {
>     PlacesUtils.showAddBookmarkUI(aBrowser.currentURI);
>   },
> 
>   /**
>    * Adds a bookmark to the page loaded in the current tab. 
>    */
>   bookmarkCurrentPage: function PCH_bookmarkCurrentPage() {
>-    PlacesUtils.showAddBookmarkUI(getBrowser().selectedBrowser);
>+    PlacesUtils.showAddBookmarkUI(getBrowser().selectedBrowser.currentURI);
>   },
> 

Please make that
this.bookmarkPage(getBrowser().selectedBrowser) instead.

Comment 6

[Dietrich Ayala (:dietrich)]

Attachment: updated fix

Comment 7

[Asaf Romano (gone)]

Comment on attachment 254327 [details] [diff] [review]
updated fix

r=mano

Comment 8

[Dietrich Ayala (:dietrich)]

/cvsroot/mozilla/browser/base/content/browser-places.js,v  <--  browser-places.js
new revision: 1.26; previous revision: 1.25

Comment 9

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv