If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

No "Bookmark This Tab" and "Bookmark All Tabs" menuitms in the tabbar context menu

RESOLVED FIXED in Firefox 3 alpha2

Status

()

Firefox
Bookmarks & History
P2
normal
RESOLVED FIXED
11 years ago
8 years ago

People

(Reporter: mano, Assigned: mano)

Tracking

Trunk
Firefox 3 alpha2
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Fx2-parity])

Attachments

(2 attachments, 1 obsolete attachment)

The "Bookmak This Tab" and "Bookmark All Tabs" menuitems of the context menu for the tabbar are not available in places-bookmarks builds.
Priority: -- → P2
Summary: No "Bookmak This Tab" and "Bookmark All Tabs" menuitms in the tabbar context menu → No "Bookmark This Tab" and "Bookmark All Tabs" menuitms in the tabbar context menu
Whiteboard: [Fx2-parity]
Created attachment 252266 [details] [diff] [review]
patch
Attachment #252266 - Flags: review?(sspitzer)
Comment on attachment 252266 [details] [diff] [review]
patch

r=sspitzer

sorry for the delay, asaf.  thanks for your patience.
Attachment #252266 - Flags: review?(sspitzer) → review+
mozilla/browser/base/content/browser.js 1.756
mozilla/browser/base/content/browser-places.js 1.22
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Created attachment 254317 [details] [diff] [review]
fix regression

This fix broke adding bookmarks:

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/browser/base/content&command=DIFF_FRAMESET&file=browser-places.js&rev2=1.22&rev1=1.21

fix attached.
Attachment #254317 - Flags: review?(mano)
Comment on attachment 254317 [details] [diff] [review]
fix regression

>Index: browser/base/content/browser-places.js
>===================================================================
>RCS file: /cvsroot/mozilla/browser/base/content/browser-places.js,v
>retrieving revision 1.25
>diff -u -8 -p -r1.25 browser-places.js
>--- browser/base/content/browser-places.js	5 Feb 2007 17:46:50 -0000	1.25
>+++ browser/base/content/browser-places.js	7 Feb 2007 18:53:12 -0000
>@@ -62,17 +62,17 @@ var PlacesCommandHook = {
>   bookmarkPage: function PCH_bookmarkCurrentPage(aBrowser) {
>     PlacesUtils.showAddBookmarkUI(aBrowser.currentURI);
>   },
> 
>   /**
>    * Adds a bookmark to the page loaded in the current tab. 
>    */
>   bookmarkCurrentPage: function PCH_bookmarkCurrentPage() {
>-    PlacesUtils.showAddBookmarkUI(getBrowser().selectedBrowser);
>+    PlacesUtils.showAddBookmarkUI(getBrowser().selectedBrowser.currentURI);
>   },
> 

Please make that
this.bookmarkPage(getBrowser().selectedBrowser) instead.
Attachment #254317 - Flags: review?(mano) → review-
Created attachment 254327 [details] [diff] [review]
updated fix
Attachment #254317 - Attachment is obsolete: true
Attachment #254327 - Flags: review?(mano)
Comment on attachment 254327 [details] [diff] [review]
updated fix

r=mano
Attachment #254327 - Flags: review?(mano) → review+
/cvsroot/mozilla/browser/base/content/browser-places.js,v  <--  browser-places.js
new revision: 1.26; previous revision: 1.25
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.