367025 - "Bookmark All Tabs" command is always enabled in places-bookmarks builds

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Asaf Romano (gone)]

Comment 1

[Asaf Romano (gone)]

Attachment: patch

Comment 2

[(not reading, please use [e-mail] instead)]

both the original code (before asaf's patch) and the new code (after his patch) have this seenURIs concept, which I am guessing is because (until dietrich finishes his major surgery) URIs are the unique keys in the places backend.

fx 2.0 would allow you to bookmark the same uri multiple times (even in the same folder), so we should fix that (or decide that this is desirable, even once the places data model is fixed.)

if there isn't a bug on this already, I'll log it.

Comment 3

[(not reading, please use [e-mail] instead)]

Comment on attachment 251520 [details] [diff] [review]
patch

r=sspitzer

one nit:

+  // nsIDOMEventListenr

typo:  nsIDOMEventListenr -> nsIDOMEventListener

but please log a spin off bug about the unique-uri-issue (and cc dietrich).

Comment 4

[Asaf Romano (gone)]

mozilla/browser/base/content/browser-menubar.inc 1.105
mozilla/browser/base/content/browser-places.js 1.20
mozilla/browser/base/content/browser-sets.inc 1.89
mozilla/browser/base/content/browser.js 1.754
mozilla/browser/base/content/browser.xul 1.335

Comment 5

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv