367131 - Allow click and drag event creation in time scale (hours column)

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, enhancement)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de-DE; rv:1.9a2pre) Gecko/20070115 Calendar/0.6a1

At the moment, if there is an event where you want to create a new one by click and drag, it is not possible if the whole pane at start and end time is blocked by events. So it would be good if the user can click and drag in the time scale and the start and end time taken there are used to create a new event in the pane.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

I'd second this. A margin around the event boxes might be the solution.

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

Christian, do you have an idea how this could be fixed?

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

I think we should leave a small margin on the left of *each* event column in the multiday views, this way you always have room to create the events.

Comment 5

[[e-mail]]

This is a simple and effective fix that's similar to what other calendars do.

Comment 6

[Decathlon]

Attachment: patch - v1

(In reply to comment #4)
> I think we should leave a small margin on the left of *each* event column in
> the multiday views, this way you always have room to create the events.

Could something like this patch be fine?

Comment 8

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 474149 [details] [diff] [review]
patch - v1

Nice and simple patch, thanks for taking care!

I'm going to piggyback a small fix in the memory calendar, where the cal. prefix was missing. I noticed this bug while testing this patch (even though its totally unrelated :)

r=philipp

Comment 9

[Philipp Kewisch [:Fallen][📱📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/f20238339e58>
-> FIXED

Comment 10

[Merike Sell (:merike)]

Wouldn't it be more intuitive if that space was on the right side (in ltr languages that is)? This is what other calendars I've seen leaving that space do (Outlook & Google). Also if you are adding an event that collides with others you likely look at other events first to make sure it's ok and then create the event. Having it on the left side means eye focus going from right to left instead of more natural left to right direction.

Comment 11

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 474149 [details] [diff] [review]
patch - v1

Sounds like a logical reason, lets have a ui-reviewer decide on this.

Comment 12

[Decathlon]

I think Merike is right, it seems more natural adding events on the right side.
I have to reopen the bug because the patch causes a misalignment on the time-bar (the box with anonid="top-box" is also present inside the "calendar-time-bar" binding).
I'm going to attach a patch that fixes after the ui review.

Comment 13

[Andreas Nilsson (:andreasn)]

Hm, bitrotted?

Comment 14

[Andreas Nilsson (:andreasn)]

Oh, crap, of course it's bitrotted, since that's already checked in and I thought there was a new patch. So you want me to ui-review if we should do what's proposed in Comment 10?
I don't have any big objections to do that, so lets do that. ui-r+

Comment 15

[Decathlon]

Attachment: patch - margin on the right side

This  patch moves the margin on the right side and fixes the misalignment on the time-bar.
By the way, what about the width? I think 4 pixels might be good as well, but less than 4 pixels seems definitely too little and more than 5 pixels seems a waste of space.

Comment 16

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 477056 [details] [diff] [review]
patch - margin on the right side

r=philipp

Comment 17

[Philipp Kewisch [:Fallen][📱📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/bf7ef020ee97>
-> FIXED

Comment 18

[Philipp Kewisch [:Fallen][📱📆]]

Backported to comm-1.9.2 <http://hg.mozilla.org/releases/comm-1.9.2/rev/4d9e66f4bda5> and <http://hg.mozilla.org/releases/comm-1.9.2/rev/c9781dc275b7>

a=philipp