BUILD: Current Mac trunk build STEPS TO REPRODUCE: 1) Load https://bugzilla.mozilla.org/attachment.cgi?id=251778&action=edit 2) Move the window to the right-hand side of the screen 3) Ctrl-click in the attachment frame near the right edge 4) Hover the "This frame" option EXPECTED RESULTS: See a submenu. ACTUAL RESULTS: Submenu is mostly off the screen, instead of going off to the left of the main menu. This is a cocoa widget regression, at least based on the date when it appeared (2006-09-28) and the fact that it doesn't happen on Linux.
11 years ago
Created attachment 252675 [details] [diff] [review] fix Turns out nsCocoaWindow didn't implement WidgetToScreen, and the only place where that was asked of a window was in the popup menu code.
Comment on attachment 252675 [details] [diff] [review] fix Please null check mPopupContentView in both places. We don't want to crash if somebody tries to call that on a window that isn't a popup. Also, we should probably implement the function for non-popups.
Colin confirms that this fixes bug 340585 too (the ESM uses WidgetToScreen for mouse scroll events).
Actually it doesn't seem to be working anymore. Just tried it and it's not working. I think that bug is a focus (event?) issue -- if you'll notice the knob on the scrollbar is grey instead of blue -- that indicates the scrollbar is in the background.
Created attachment 252749 [details] [diff] [review] fix v2
Comment on attachment 252749 [details] [diff] [review] fix v2 tested, works. Is returning the same values my patch was.
fixed on trunk