Closed Bug 367356 Opened 18 years ago Closed 18 years ago

Error: erel has no properties (XMLPrettyPrint.xml)

Categories

(Firefox Graveyard :: RSS Discovery and Preview, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dao, Assigned: dao)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
Error: erel has no properties
Source File: chrome://browser/content/browser.js
Line: 5059

... when viewing a local xml file.
Attachment #251915 - Flags: review?(jonas)
Attached patch patchSplinter Review
Attachment #251915 - Attachment is obsolete: true
Attachment #251916 - Flags: review?(jonas)
Attachment #251915 - Flags: review?(jonas)
Comment on attachment 251916 [details] [diff] [review]
patch

Robert Sayre is a better reviewer for this since he's on blame.
Attachment #251916 - Flags: review?(jonas) → review?(sayrer)
Comment on attachment 251916 [details] [diff] [review]
patch

looks good to me
Attachment #251916 - Flags: review?(sayrer) → review?(gavin.sharp)
Comment on attachment 251916 [details] [diff] [review]
patch

Good catch on the regexp (\s+ vs. \s)
Attachment #251916 - Flags: review?(gavin.sharp) → review+
Whiteboard: [checkin needed]
Checked in:
mozilla/browser/base/content/browser.js  1.755
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: