367672 - CSS 2 system color InfoBackground doesn't work properly on mac

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Stefan [:stefanh]]

InfoBackground seems to return white on mac instead of the yellow tooltip background-color. I can't really find any substantial documentation of the constant we're using in nsLookAndFeel.mm, so I'm not sure about what it's suppose to return. But since the fallback color isn't used, I assume kThemeBrushNotificationWindowBackground is returning white.

Comment 1

[Stefan [:stefanh]]

Attachment: Testcase

Comment 2

[Stefan [:stefanh]]

Attachment: Use hard-coded color FFFFC7

I don't have any other idea than hard-coding the color value. We don't use any color constant in the native theme code either (see bug 351108 where I changed the tooltip bgcolor) so I guess this is the way to go.

Comment 3

[Stefan [:stefanh]]

CC:ing Mano and Robert Strong since "InfoBackground" is used in two Pinstripe files (Rob seems to have touched one file for a while ago):
toolkit/themes/pinstripe/mozapps/extensions/update.css
toolkit/themes/pinstripe/mozapps/update/updates.css

Do you guys want a tooltip background here?

Comment 4

[Karsten Düsterloh]

JFTR: I do see a similar problem with SM GTK1 builds: the testcase here has background colour grey, while tooltips are yellow...

Comment 5

[Josh Aas]

Comment on attachment 252235 [details] [diff] [review]
Use hard-coded color FFFFC7

fine with me

Comment 6

[Robert Strong (they/them - no direct email)]

(In reply to comment #3)
> ...
> Do you guys want a tooltip background here?
Barring the OS providing an appropriate color I believe this is the way to go.

Comment 7

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 252235 [details] [diff] [review]
Use hard-coded color FFFFC7

sr=pink, just make sure nobody else is using this and not expecting yellow.

Comment 8

[Stefan [:stefanh]]

JFTR: xforms.css uses InfoBackground for ephermal messages. I'm sure the intention is to have the same background as a tooltip here. So, the patch will improve  the look of those "tooltip-like" messages.

Comment 9

[Karsten Düsterloh]

Comment on attachment 252235 [details] [diff] [review]
Use hard-coded color FFFFC7

Landed on trunk.

Comment 10

[Stefan [:stefanh]]

Fixed (thanks for the check-in!)