367769 - wrapped links in text/plain; format=flowed don't get linked properly

Status: RESOLVED DUPLICATE of bug 344288

(Thunderbird :: Mail Window Front End, defect)

Description

[Dave Miller [:justdave]]

I get email from Safari users frequently...  Safari sends plaintext mail as format=flowed; delsp=yes.  It also wraps the links in the body of the message.  When Thunderbird hyperlinks it, it ends up truncating the URL that gets linked to at the newline, even though it's not displayed with a newline in the middle, so I wind up having to copy/paste the URL to the browser instead of being able to click on it (because the clickable part is incomplete).

This sounds like it's related to but 5351, but I'm filing a new bug because it may be able to be worked around separately.  The problem with 5351 is that the Text-to-HTML converter is line-based, so it doesn't recognize things that span multiple lines.  The problem here is that because of the format=flowed, this logically *is* only one line, it's just the way it's encoded.  I'm suspecting this could be fixed by processing the format=flowed stuff first before sending it through the text-to-html converter.

I'm told on IRC that benb is interested in format=flowed bugs, so CCing him.

Comment 1

[Ben Bucksch (:BenB)]

Thanks for having the done homework and finding bug 5351.

> The problem with 5351 is that the Text-to-HTML converter is line-based,
> so it doesn't recognize things that span multiple lines. I'm suspecting
> this could be fixed by processing the format=flowed stuff first before
> sending it through the text-to-html converter.

Actually, the TXT->HTML converter is *not* linebased, but written so that it can process whole paragraphs. It's *libmime* which is line-based, and the flowed processor is in libmime. It indeed is linebased (I just checked).

I think it's a bad idea of Apple Mail (you meant that, not Safari, right?) to send links with spaces/linebreaks. But as long as they do, we'll have to suffer from our bug 5351.

Comment 2

[Ben Bucksch (:BenB)]

(FWIW, it's mimetpfl.cpp, |if(flowed)|. The difference between flowed and fixed lines there is just that the latter gets a <br> afterwards. Both are lines in the output HTML source.

Comment 3

[Dave Miller [:justdave]]

Yeah, I meant Apple Mail, sorry. :)

In this case, there's no space in the middle of the link.  It's one straight link in the message viewer, the blue+underline just stops in the middle of it.  Other than the blue+underline stopping, there's no way to tell it wasn't together to begin with except to view-source on it.

Comment 4

[Ben Bucksch (:BenB)]

OK, I would have thought that you'd see a space inbetween due to a linebreak in the output HTML.
In any case, if I read the source correctly, the flowed processor processes line by line, so I don't see how this is different from bug 5351.

Comment 5

[Scott MacGregor]

This sounds like a dupe of Bug 344288 too.

Comment 6

[Ben Bucksch (:BenB)]

Yup, indeed, bug 344288 seems to fix 5351 for f=f, similar to the workaround proposed in bug 5351 comment 17 (which was about plaintext), as far as I can see.