Closed Bug 368077 Opened 18 years ago Closed 17 years ago

Right-click in unfocused window brings up dysfunctional context menu

Categories

(Core :: Widget: Cocoa, defect)

PowerPC
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9beta1

People

(Reporter: bzbarsky, Assigned: smichaud)

References

Details

Attachments

(1 file)

NOTE: This is basically a refiling on bug 367303 since in his infinite wisdom Josh decided to WORKSFORME it on a technicality instead of actually addressing the problem.  Thanks for forcing me to spend the time to file this again, Josh!  

BUILD: Current trunk build

STEPS TO REPRODUCE:
1)  Hook up a multi-button mouse to your mac
2)  Start firefox
3)  Load any page with a link on it (e.g. this bug page)
4)  Focus some other app while keeping said link visible (e.g. click on
    desktop and make sure no Finder windows are open).
5)  Right-click on the link without focusing the Firefox window first

ACTUAL RESULTS:  Context menu comes up, but the Firefox window is not focused. 
The context menu options sometimes work, sometimes not, usually not.  There's no feedback as you hover over said menu options.

EXPECTED RESULTS:  The context menu should work correctly and consistently if we're going to bring one up.
Flags: blocking1.9?
Firefox not focusing is expected as per the other bug. The context menu not disappearing when you focus click elsewhere is bug 339945 (though you didn't actually mention that). And the highlight bug might actually be related to bug 357475.

And I can't actually reproduce the options not working using the latest Minefield. Every time it seems to work for me, though it doesn't highlight.
OS: Linux → Mac OS X
Hardware: PC → Macintosh
Blocks: 326469
This should get resolved one way or another; that might be making the context menu options do the right thing as far as showing state or whatever.
Flags: blocking1.9? → blocking1.9+
Doing some quick testing on some native Cocoa apps, the context menu shows up and works fine, and the items are highlighted. The window you invoked the context menu on does *not* get makeKeyAndOrderFront: though. I'd probably say err on the side of doing what native apps do, as that's going to be less confusing in general.

(I'd never tried right clicking in background windows before, actually, I was kind of surprised at the behavior of native apps -- although it makes sense why that would happen, from a technical standpoint).
Target Milestone: --- → mozilla1.9alpha6
I have a patch for this, but it depends heavily on the patch in 339945. I'll post it when that patch is finalized.
Assignee: joshmoz → cbarrett
Depends on: 339945
Target Milestone: mozilla1.9alpha6 → mozilla1.9alpha5
Attached patch fix v1.0Splinter Review
Here is the fix. It's very short, I'm assuming that there is already a handler somewhere for the mouse moved events and that's what's picking these up.
Attachment #265281 - Flags: review?(joshmoz)
Comment on attachment 265281 [details] [diff] [review]
fix v1.0

I can't actually use the context menu from Firefox when the app is in the backkground. The option highlighting does work now, but clicking on an item doesn't perform the action.

I don't want to land this until we understand what is going on with that.
Attachment #265281 - Flags: review?(joshmoz) → review-
Moving to A6 as we're out of time.
Target Milestone: mozilla1.9alpha5 → mozilla1.9alpha6
Assignee: cbarrett → smichaud
Target Milestone: mozilla1.9alpha6 → mozilla1.9beta2
Depends on: 387164
Fixed by patch for bug 387164, which just landed on trunk.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: