forward/back in stand-alone message window doesn't cross folders

RESOLVED FIXED

Status

RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Tracking

(Blocks: 1 bug, {fixed1.8.1.2})

Trunk
x86
Mac OS X
fixed1.8.1.2

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
Created attachment 252839 [details] [diff] [review]
proposed fix

There are a couple issues with forward/back crossing folders using the stand-alone message window. Also, you need to do next unread twice to get it to cross folders w/ the standalone message window. The patch I'm about to attach fixes both problems, as well as an issue where the drop down menu for the back/forward buttons doesn't notice when you change folders so it shows the wrong folder in the menu, in that case.
(Assignee)

Comment 1

12 years ago
Comment on attachment 252839 [details] [diff] [review]
proposed fix

this fixes the folder name n the drop down, when you've crossed folders:

+  msgWindow.openFolder = msgfolder;
+  

this fixes the need to do next unread twice to cross folders:

+      // accessing the db causes the folder loaded notification to get sent
+      // for local folders.
+      var db = msgfolder.getMsgDatabase(msgWindow);

and I added a method LoadNavigatedToMessage for messageWindow.js and msgMail3PaneWindow.js to differentiate the way they need to handle loading messages after back/forward navigation.
Attachment #252839 - Flags: superreview?(mscott)
(Assignee)

Comment 2

12 years ago
Karsten, you'll probably be interested in this patch for SM if you have forward/back buttons.

Updated

12 years ago
Attachment #252839 - Flags: superreview?(mscott) → superreview+
(Assignee)

Comment 3

12 years ago
fixed on trunk and branch
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Keywords: fixed1.8.1.2
Resolution: --- → FIXED
(In reply to comment #2)
> Karsten, you'll probably be interested in this patch for SM if you have
> forward/back buttons.

Moved to bug 399787.
Blocks: 399787
You need to log in before you can comment on or make changes to this bug.