368362 - vista integration: fix nsPostupdateWindow.js / nsUpdateService.js.in / thunderbirdHelper.exe

Status: RESOLVED WORKSFORME

(Thunderbird :: General, defect)

Description

[(not reading, please use [e-mail] instead)]

for thunderbird, there are three places we need to worry about:

1) in nsPostUpdateWindow.js, we'll need to fix checkRegistry() [not yet landed]
for tbird.

for firefox, we look for the -requestPending (part of robert's dde work for
firefox) on the FirefoxHTML key.

+function checkRegistry()
+{
+  // XXX todo
+  // this is firefox specific
+  // figure out what to do about tbird and sunbird, etc   
+  LOG("checkRegistry");
+     
+  var result = false;
+  try {
+    var key = new RegKey();
+    key.open(RegKey.prototype.ROOT_KEY_CLASSES_ROOT,
"FirefoxHTML\\shell\\open\\command", key.ACCESS_READ);
+    var commandKey = key.readStringValue("");
+    LOG("commandKey = " + commandKey);
+    // if "-requestPending" is not found, we need to do the cleanup
+    result = (commandKey.indexOf("-requestPending") == -1);

2) mozapps/update/src/nsUpdateService.js.in

+#ifdef MOZ_PHOENIX
+        // for now, this is firefox only.  
+        // we need to fix both nsPostUpdateWin.js and 
+        // the uninstaller to work for thunderbird and sunbird
+        //
         // Perform platform-specific post-update processing.
         if (POST_UPDATE_CONTRACTID in Components.classes) {
           Components.classes[POST_UPDATE_CONTRACTID].
               createInstance(Components.interfaces.nsIRunnable).run();
         }
+#endif

once we fix nsPostUpdateWin.js to be tbird friendly we can remove that ifdef.

3)  we'd need a thunderbirdHelper.exe (see #368353, it's an app based on our
NSIS uninstaller that does all the log copying and registry clean up that
nsPostUpdateWin.js used to do.)

I'll log a spin on bug on these issues.

note, we need thunderbirdHelper.exe for windows xp/2k too.

Comment 1

[Robert Strong (they/them - no direct email)]

Fixed this on trunk so Thunderbird no longer requires nsPostupdateWindow.js and uses helper.exe