User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:220.127.116.11) Gecko/20061204 Firefox/18.104.22.168 Build Identifier: thunderbird 2.0 beta 2 seems like there is a little problem when displaying the colors of tags in the dropdown menu (and also in the list in the options-dialog). if you create tags WITHOUT a color information and then tags WITH a color information, the tags without the color inherit the color from the later tag. Reproducible: Always Steps to Reproduce: 1) click the "tag" button and then "new tag…" 2) name the new tag "X" and DON'T choose a color. click "OK" 3) create another tag "Y", again without choosing a color 4) create another tag "Z", but this time choose a color 5) click the "tag" button again. "X" and "Y" inherit the color choosen for "Z" Actual Results: see step 5) if you choose red as a color for "Z", then "X" and "Y" also become red. Expected Results: when not choosing a color, the defaulttextcolor should be black, but not take the color information from an unrelated tag.
->NEW on Mozilla/5.0 (X11; U; Linux i686; en-US; rv:22.214.171.124pre) Gecko/20070127 Thunderbird/2.0pre ID:2007012703
This is a regression of bug 354726, where the error code for GetColorForKey was dropped.
Created attachment 255452 [details] [diff] [review] set default colour to be empty GetColorForKey doesn't do anything wrt the result in the error case, so we can safely empty the string before looking for colours.
Comment on attachment 255452 [details] [diff] [review] set default colour to be empty Karsten, can you land this on the branch too?
Landed on trunk and MOZILLA_1_8_BRANCH.
I included this fix in the SeaMonkey 1.1.1 release tag.
adding the fixed126.96.36.199 keyword since karsten kindly landed this on the mozilla 1.8 branch.
verified on the 1.8 branch using Win XP. I verified using the Tbird candidate build, version 188.8.131.52 (20070326). I was not able to reproduce using the original STR. Adding verified keyword for the branch.